Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for go 1.12 and add support for go 1.14 in Travis. #522

Merged
merged 4 commits into from
Apr 27, 2020

Conversation

wyk9787
Copy link
Contributor

@wyk9787 wyk9787 commented Apr 16, 2020

Since the release of go 1.14, go 1.12 is not supported any more: https://golang.org/doc/devel/release.html#policy.

@wyk9787 wyk9787 changed the title Remove support for Go 1.12 in Travis. Remove support for go 1.12 in Travis. Apr 16, 2020
Copy link
Collaborator

@aalexand aalexand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify in the PR title that this removes 1.12 support and adds 1.14?

@wyk9787 wyk9787 changed the title Remove support for go 1.12 in Travis. Remove support for go 1.12 and add support for go 1.14 in Travis. Apr 17, 2020
@wyk9787
Copy link
Contributor Author

wyk9787 commented Apr 17, 2020

Could you clarify in the PR title that this removes 1.12 support and adds 1.14?

Done.

@codecov-io
Copy link

codecov-io commented Apr 17, 2020

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   67.11%   67.11%           
=======================================
  Files          37       37           
  Lines        7627     7627           
=======================================
  Hits         5119     5119           
  Misses       2103     2103           
  Partials      405      405           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e0a84...093a2a6. Read the comment docs.

@aalexand aalexand requested a review from nolanmar511 April 17, 2020 01:59
@wyk9787 wyk9787 merged commit 8f1c0db into google:master Apr 27, 2020
@wyk9787 wyk9787 deleted the travis branch April 30, 2020 17:02
giordano added a commit to JuliaPackaging/Yggdrasil that referenced this pull request Nov 13, 2020
* Update pprof to latest revision

Bump from 20191205061153 => 20201109224723

My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`)

Includes:
- google/pprof#564
- google/pprof#575
- google/pprof#574
- google/pprof#571
- google/pprof#572
- google/pprof#570
- google/pprof#562
- google/pprof#561
- google/pprof#565
- google/pprof#560
- google/pprof#563
- google/pprof#557
- google/pprof#554
- google/pprof#552
- google/pprof#545
- google/pprof#549
- google/pprof#547
- google/pprof#541
- google/pprof#534
- google/pprof#542
- google/pprof#535
- google/pprof#531
- google/pprof#530
- google/pprof#528
- google/pprof#522
- google/pprof#525
- google/pprof#527
- google/pprof#519
- google/pprof#520
- google/pprof#517
- google/pprof#518
- google/pprof#514
- google/pprof#513
- google/pprof#510
- google/pprof#508
- google/pprof#506
- google/pprof#509
- google/pprof#504

* Update P/pprof/build_tarballs.jl - use a real version number

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

* Remove now unused `timestamp`

* [pprof] Use `GitSource`

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
gmarin13 pushed a commit to gmarin13/pprof that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants