Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test --x86-asm-syntax=intel only on amd64 #561

Merged
merged 11 commits into from
Oct 7, 2020
Merged

Conversation

kalyanac
Copy link
Contributor

Some llvm-objdump installations may not include all backends and will cause failures.

Some llvm-objdump installations may not include all backends and will cause failures.
@kalyanac kalyanac requested a review from aalexand September 26, 2020 00:55
@google-cla google-cla bot added the cla: yes label Sep 26, 2020
@kalyanac kalyanac marked this pull request as draft September 26, 2020 01:03
@kalyanac
Copy link
Contributor Author

Sorry about the multiple commits. I tried to create the commit directly from Github's editor and that did not go well.

@kalyanac
Copy link
Contributor Author

Test failures are benign and unrelated.

@kalyanac kalyanac marked this pull request as ready for review September 26, 2020 02:15
aalexand
aalexand previously approved these changes Sep 26, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2020

Codecov Report

Merging #561 into master will decrease coverage by 1.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   68.46%   67.12%   -1.34%     
==========================================
  Files          78       78              
  Lines       16108    14062    -2046     
==========================================
- Hits        11028     9439    -1589     
+ Misses       4225     3790     -435     
+ Partials      855      833      -22     
Impacted Files Coverage Δ
internal/driver/settings.go 67.21% <0.00%> (-5.01%) ⬇️
...ithub.com/google/pprof/internal/driver/settings.go 67.21% <0.00%> (-5.01%) ⬇️
internal/binutils/addr2liner_llvm.go 64.51% <0.00%> (-4.06%) ⬇️
profile/proto.go 79.53% <0.00%> (-3.73%) ⬇️
src/github.com/google/pprof/profile/proto.go 79.53% <0.00%> (-3.73%) ⬇️
internal/driver/flags.go 15.38% <0.00%> (-3.67%) ⬇️
...c/github.com/google/pprof/internal/driver/flags.go 15.38% <0.00%> (-3.67%) ⬇️
...b.com/google/pprof/internal/binutils/addr2liner.go 65.43% <0.00%> (-3.46%) ⬇️
.../google/pprof/internal/binutils/addr2liner_llvm.go 70.96% <0.00%> (-3.32%) ⬇️
internal/driver/fetch.go 62.88% <0.00%> (-3.17%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf8798...814099a. Read the comment docs.

@kalyanac
Copy link
Contributor Author

Failure is unrelated.

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@29d1258). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #561   +/-   ##
=========================================
  Coverage          ?   67.14%           
=========================================
  Files             ?       78           
  Lines             ?    14072           
  Branches          ?        0           
=========================================
  Hits              ?     9449           
  Misses            ?     3788           
  Partials          ?      835           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d1258...e2b2322. Read the comment docs.

@kalyanac kalyanac merged commit d1ec22a into master Oct 7, 2020
@kalyanac kalyanac deleted the llvm-objdump-intel-asm branch October 7, 2020 01:43
giordano added a commit to JuliaPackaging/Yggdrasil that referenced this pull request Nov 13, 2020
* Update pprof to latest revision

Bump from 20191205061153 => 20201109224723

My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`)

Includes:
- google/pprof#564
- google/pprof#575
- google/pprof#574
- google/pprof#571
- google/pprof#572
- google/pprof#570
- google/pprof#562
- google/pprof#561
- google/pprof#565
- google/pprof#560
- google/pprof#563
- google/pprof#557
- google/pprof#554
- google/pprof#552
- google/pprof#545
- google/pprof#549
- google/pprof#547
- google/pprof#541
- google/pprof#534
- google/pprof#542
- google/pprof#535
- google/pprof#531
- google/pprof#530
- google/pprof#528
- google/pprof#522
- google/pprof#525
- google/pprof#527
- google/pprof#519
- google/pprof#520
- google/pprof#517
- google/pprof#518
- google/pprof#514
- google/pprof#513
- google/pprof#510
- google/pprof#508
- google/pprof#506
- google/pprof#509
- google/pprof#504

* Update P/pprof/build_tarballs.jl - use a real version number

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

* Remove now unused `timestamp`

* [pprof] Use `GitSource`

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
gmarin13 pushed a commit to gmarin13/pprof that referenced this pull request Dec 17, 2020
* Test --x86-asm-syntax=intel only on amd64

Some llvm-objdump installations may not include all backends and will cause failures.

* Update binutils_test.go

* Test --x86-asm-syntax=intel only on amd64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants