Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url to "Interpret the call graph" section in pprof legend. #530

Merged
merged 5 commits into from
Apr 30, 2020

Conversation

wyk9787
Copy link
Contributor

@wyk9787 wyk9787 commented Apr 30, 2020

Fixes: #493

Example:
Screen Shot 2020-04-29 at 6 10 06 PM

@wyk9787 wyk9787 requested a review from nolanmar511 April 30, 2020 01:11
@codecov-io
Copy link

codecov-io commented Apr 30, 2020

Codecov Report

Merging #530 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files          37       37           
  Lines        7627     7629    +2     
=======================================
+ Hits         5114     5116    +2     
  Misses       2105     2105           
  Partials      408      408           
Impacted Files Coverage Δ
internal/report/report.go 30.83% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11b803...815bd6b. Read the comment docs.

@wyk9787
Copy link
Contributor Author

wyk9787 commented Apr 30, 2020

Done with changes.

@wyk9787 wyk9787 merged commit fc25d7d into google:master Apr 30, 2020
giordano added a commit to JuliaPackaging/Yggdrasil that referenced this pull request Nov 13, 2020
* Update pprof to latest revision

Bump from 20191205061153 => 20201109224723

My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`)

Includes:
- google/pprof#564
- google/pprof#575
- google/pprof#574
- google/pprof#571
- google/pprof#572
- google/pprof#570
- google/pprof#562
- google/pprof#561
- google/pprof#565
- google/pprof#560
- google/pprof#563
- google/pprof#557
- google/pprof#554
- google/pprof#552
- google/pprof#545
- google/pprof#549
- google/pprof#547
- google/pprof#541
- google/pprof#534
- google/pprof#542
- google/pprof#535
- google/pprof#531
- google/pprof#530
- google/pprof#528
- google/pprof#522
- google/pprof#525
- google/pprof#527
- google/pprof#519
- google/pprof#520
- google/pprof#517
- google/pprof#518
- google/pprof#514
- google/pprof#513
- google/pprof#510
- google/pprof#508
- google/pprof#506
- google/pprof#509
- google/pprof#504

* Update P/pprof/build_tarballs.jl - use a real version number

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

* Remove now unused `timestamp`

* [pprof] Use `GitSource`

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
gmarin13 pushed a commit to gmarin13/pprof that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc] how to read pprof dot graph?
4 participants