Only run TestDisasm on amd64

[zhsj]

It seems objdump is not able to dump other architecture object.

[zhsj]

hmm, I'm not using master, it has been fixed.

[zhsj]

Not really fixed...

Still failing

=== RUN   TestDisasm
    binutils_test.go:205: Disasm: unexpected error [/usr/bin/objdump --disassemble-all --demangle --no-show-raw-insn --line-numbers --start-address=0x0 --stop-address=0xffffffffffffffff testdata/exe_linux_64]: exit status 1
--- FAIL: TestDisasm (0.04s)
=== RUN   TestDisasmIntelSyntax
    binutils_test.go:228: This test only works on x86_64 Linux or macOS as it tests Intel asm syntax
--- SKIP: TestDisasmIntelSyntax (0.00s)

/usr/bin/objdump: testdata/exe_linux_64: file format not recognized

[codecov-io]

Codecov Report

Merging #570 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #570   +/-   ##
=======================================
  Coverage   67.14%   67.14%           
=======================================
  Files          78       78           
  Lines       14072    14072           
=======================================
  Hits         9449     9449           
  Misses       3788     3788           
  Partials      835      835           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1066cbb...924778f. Read the comment docs.

[kalyanac]

From your error, it tooks like objdump is not able to recognize Linux binaries.
What architecture are you running the tests on? And what is the objdump version you are using?

[zhsj]

I'm on arm.

$ uname -a
Linux abel 4.19.0-11-armmp-lpae #1 SMP Debian 4.19.146-1 (2020-09-17) armv7l GNU/Linux

$ objdump --version
GNU objdump (GNU Binutils for Debian) 2.35.1
Copyright (C) 2020 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) any later version.
This program has absolutely no warranty.

$ cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux bullseye/sid"
NAME="Debian GNU/Linux"
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

[zhsj]

on x86 system, it seems objdump can't dump arm64 as well.

$ cat a.c 
void main(){}
$ aarch64-linux-gnu-gcc a.c 
$ file a.out 
a.out: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, BuildID[sha1]=d65928b56beaf07019c6d04159c7e0ed28a7917f, for GNU/Linux 3.7.0, not stripped
$ /usr/bin/objdump --disassemble-all --demangle --no-show-raw-insn --line-numbers --start-address=0x0 --stop-address=0xffffffffffffffff a.out 

a.out:     file format elf64-little

/usr/bin/objdump: can't disassemble for architecture UNKNOWN!

$

$ objdump --version
GNU objdump (GNU Binutils for Debian) 2.35.1
Copyright (C) 2020 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) any later version.
This program has absolutely no warranty.

$ uname -a
Linux zhsj-debian 5.8.0-1-amd64 #1 SMP Debian 5.8.7-1 (2020-09-05) x86_64 GNU/Linux

[kalyanac]

Can you try with llvm-objdump? pprof will now prefer llvm-objdump if it is available. That should help the test pass.

[zhsj]

llvm-objdump works.

[kalyanac]

Thank you for checking. I think it still makes sense to merge this PR. llvm-objdump installation may not always have all the backends available. Instead of trying to parse the support and run the test, we will limit the test to only x86-64.

If you reopen the PR, I can merge it. If not, I will submit a new PR.