Release v1.4.0 #378
Merged
Release v1.4.0 #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missed bump to dev
If domain has size 2^17, NTT on size 2^16 coset generated by `-1` fails. This happens due to index in `BatchMulKernel` overflowing, fixed by using `long` instead of `int`.
* BW scalar field is now the same as BLS base field * add poseidon * add merkle tree builder * poseidon rust bindings * implement rust bindings * add doc comments * remove global poseidon constants * add custom constants API and script for generating new constants * add the rest of the curves for poseidon * add all the curves for real * misname bls12-377 * typo * partial rounds * minor fixes * small tweak for big performance boost * add CHK_INIT_IF_RETURN --------- Co-authored-by: DmytroTym <dmytrotym1@gmail.com>
bump rust crate versions
Co-authored-by: hadaringonyama <hadar@ingonyama.com>
Change rust example deps to use paths Co-authored-by: Leon Hibnik <107353745+LeonHibnik@users.noreply.github.com>
* fix display and debug traits * leave only one impl for printing scalars
Co-authored-by: hadaringonyama <hadar@ingonyama.com>
- Mixed-radix NTT orderings support - radix-2 small refactor: split core logic to function and renamed ct_butterfly to dit - testing both radix2 and mixed-radix algs for all ntt tests
NTTConfig -> PoseidonConfig
multi-GPU support
#365 but without Rust which for now doesn't work.
This PR fixes the conflicts between main and dev
Co-authored-by: Leon Hibnik <107353745+LeonHibnik@users.noreply.github.com>
* Improved MSM * Zero point handling in large buckets * Fixed affine zero point conversion for arkworks * cargo fmt * Addressed comments * MSM comments * All zero scalars case handled * clang format
|
I verified the ntt part and it is correct. Edit: also need to add MSM improvements to the PR description |
LeonHibnik
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents of this release
[FEAT]: support for multi-device execution: #356
[FEAT]: full support for new mixed-radix NTT: #367, #368 and #371
[FEAT]: examples for Poseidon hash and tree builder based on it (currently only on C++ side): #375
[PERF]: MSM performance upgrades & zero point handling: #372