Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update react-scripts #1969

Merged
merged 12 commits into from
Jul 21, 2022
Merged

chore(deps): update react-scripts #1969

merged 12 commits into from
Jul 21, 2022

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jul 9, 2022

This is a replacement for #1932

github merge instructions are borked for CLI.. I didn't guess pushing to main would automatically update the PR.. and it didn't. it pushed to main, and closed the PR.

I reverted those changes and updated many things necessary for upgrading react-scripts. Build finally succeeds, but tests are failing. Build, tests, and CI checks are all passing

@SgtPooki SgtPooki force-pushed the chore/update-react-scripts branch from 323defb to a6c8341 Compare July 9, 2022 08:36
@SgtPooki SgtPooki mentioned this pull request Jul 9, 2022
23 tasks
@SgtPooki SgtPooki temporarily deployed to Deploy July 9, 2022 08:44 Inactive
@SgtPooki SgtPooki temporarily deployed to Deploy July 21, 2022 03:00 Inactive
@SgtPooki SgtPooki requested review from lidel and hacdias July 21, 2022 03:05
@SgtPooki SgtPooki temporarily deployed to Deploy July 21, 2022 03:14 Inactive
@SgtPooki SgtPooki temporarily deployed to Deploy July 21, 2022 04:26 Inactive
@SgtPooki SgtPooki self-assigned this Jul 21, 2022
@SgtPooki
Copy link
Member Author

Kicked off a test of all node versions, https://github.com/ipfs/ipfs-webui/actions/runs/2709349231, so we can see how these changes impact builds across node versions and platforms.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for making it work.

ps. i wonder if Node 18 build could work if we pass --openssl-legacy-provider (but that can be separate PR)

@SgtPooki SgtPooki merged commit 136b260 into main Jul 21, 2022
@SgtPooki SgtPooki deleted the chore/update-react-scripts branch July 21, 2022 15:30
ipfs-gui-bot pushed a commit that referenced this pull request Sep 9, 2022
## [2.18.0](v2.17.3...v2.18.0) (2022-09-09)

 CID `bafybeidb5eryh72zajiokdggzo7yct2d6hhcflncji5im2y5w26uuygdsm`

 ---

### Features

* IPNS Publishing ([#1973](#1973)) ([4ff4939](4ff4939))
* ux improvements to publish modal ([#1998](#1998)) ([ea4f632](ea4f632))

### Bug Fixes

* **ci:** parsing "ipfs-cluster-ctl peers ls" output ([#1966](#1966)) ([828e460](828e460))
* korean detection ([#2005](#2005)) ([362dab8](362dab8))
* Kubo agent text to link via ReleaseLink [#2010](#2010) ([#2011](#2011)) ([3d04988](3d04988))
* nodejs readme badges ([#1985](#1985)) ([a9e661b](a9e661b))
* remove web ui version and keep revision ([#2000](#2000)) ([42ed78d](42ed78d))
* resolve issues with automated releases  ([#1974](#1974)) ([9a7cfad](9a7cfad))

### Trivial Changes

* add missing classnames dependency ([#1977](#1977)) ([c4216b8](c4216b8))
* **deps:** update react-scripts ([#1969](#1969)) ([136b260](136b260))
* pull transifex translations ([#1996](#1996)) ([0de4267](0de4267))
* Pull transifex translations ([#2003](#2003)) ([cc51b15](cc51b15))
* **readme:** NodeJS version support info ([#1986](#1986)) ([829450d](829450d))
* **readme:** update release steps ([#1963](#1963)) ([c5b4822](c5b4822))
* Update .github/workflows/stale.yml [skip ci] ([f15818d](f15818d))
* update storybook and stories ([#2007](#2007)) ([83ceac1](83ceac1)), closes [/github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack-5](https://github.com/ipfs//github.com/storybookjs/storybook/blob/next/MIGRATION.md/issues/webpack-5)
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 2.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants