feat: IPNS Publishing #1973

hacdias · 2022-07-10T06:45:49Z

Please see PR #1857 for what happened and background on this. Closes #1482.

Generate New Key

Publishing Keys Settings Menu

Drop Down

Publish

Needs to be eyeballed by a native speaker, but this wins the google search result count for now.

It was useful in puppeteer, but now we use playwright which solves waiting logic way better via text selectors

This is basic copy that encourages sharing gateway link + disclaimer about the need for keeping node online once a day.

Most of fake/guessed progress bars overshoot, as it is better UX to "finishe sooner than be stuck at 100%" This change makes expectation always bit bigger than the rolling average between last two times.

… into feat/1482-settings

SgtPooki · 2022-07-18T17:25:32Z

@lidel so something happened with the other PR and I had to create this new one. The E2E tests seem to be failing. I tried the functionality and everything seems to work as expected. Could you take a look at the tests since you were the last working on them (as far as I remember)?

One thing that has broken e2e tests time and time again for me is modifying the package-lock and/or package.json with a different version of node. Be sure you're using node=16.12.0 and npm=8.1.0 and then do:

git checkout origin/main -- package-lock.json

SgtPooki · 2022-07-18T17:25:48Z

@lidel so something happened with the other PR and I had to create this new one. The E2E tests seem to be failing. I tried the functionality and everything seems to work as expected. Could you take a look at the tests since you were the last working on them (as far as I remember)?

@hacdias , One thing that has broken e2e tests time and time again for me is modifying the package-lock and/or package.json with a different version of node. Be sure you're using node=16.12.0 and npm=8.1.0 and then do:

git checkout origin/main -- package-lock.json

hacdias · 2022-07-20T09:00:02Z

@SgtPooki I did that, but there's dependency updates so it changed a bit. Yet, the E2E tests keep failing with:

Requiring @playwright/test second time

I know @lidel worked on the tests of this PR, so it'd be great to get some feedback here!

lidel · 2022-07-25T18:31:36Z

I finished migration to @playwright/test in #1983, will merge into this PR shortly. 🤞

When someone opens IPNS publishing they now get a hint that more info and key management can be found in Settings

lidel

Fixed E2E tests, overall lgtm, thank you @hacdias for your patience here ❤️

My hope was to have ipns over pubsub enabled everywhere when we merge this,
but I think having it in Desktop is good enough, and things may improve further
when we have delegated IPNS publishing over Reframe.

Let's wait for 👍 from a native speaker / UX folks till the end of this week,
and then merge.

juliaxbow

Alternative text suggestions:

Generate new IPNS Key

Previous text: Enter pet name of key to create.
New text: Enter a nickname for this key to generate:
Description of change: nickname instead of pet name

Drop Down

I prefer capitalizing the first letter of each word for dropdowns but not necessary

Publish

Previous text: Please wait while initial 20 copies of the updated IPNS record are being stored with the help of DHT peers.
New Text: Please wait while the initial 20 copies of the updated IPNS record are stored with the help of DHT peers.
Description of change: verb tense
Previous Text: Copy the link below and share it with your friends. IPNS address will resolve as long as your node remains available on the network to refresh IPNS record once a day.
New text: Copy the link below and share it with your friends. The IPNS address will resolve as long as your node remains available on the network once a day to refresh the IPNS record.
Description of change: Added “The” before “IPNS address” ; moved "once a day" to middle of the sentence
Question: is sharing with friends the most common use case? Consider replacing “your friends” with “others” or "your network"

TheDiscordian · 2022-07-25T21:23:50Z

Just some minor alterations to the text:

"Enter pet name of key to create." -> "Enter a name for the new key."

"Please wait while initial 20 copies of the updated IPNS record are being stored with the help of DHT peers..." -> "Please wait while an initial 20 copies of the updated IPNS record are being stored with the help of DHT peers..."

"IPNS address will resolve as long your node remains available on the network to refresh IPNS record once a day." -> "The IPNS address will resolve as long as your node remains available on the network to refresh the IPNS record once a day."

Thanks for this work, very excited to have this feature in the webUI ^-^.

hacdias · 2022-07-26T07:36:14Z

@lidel I updated the copy based on @juliaxbow's and @TheDiscordian's suggestions.

lidel · 2022-07-26T12:21:27Z

Thank you! Merging so these new labels land in main branch and our translation teams have more time to translate before we cut a new release (~next week?) for Kubo 0.15.

Side notes:

context menu is getting crowded
feel we could improve presentation of key names and CIDs (right now it is bland monospace font),
but that requires some additional UX work – let's continue in Improve UX of IPNS publishing #1993

## [2.18.0](v2.17.3...v2.18.0) (2022-09-09) CID `bafybeidb5eryh72zajiokdggzo7yct2d6hhcflncji5im2y5w26uuygdsm` --- ### Features * IPNS Publishing ([#1973](#1973)) ([4ff4939](4ff4939)) * ux improvements to publish modal ([#1998](#1998)) ([ea4f632](ea4f632)) ### Bug Fixes * **ci:** parsing "ipfs-cluster-ctl peers ls" output ([#1966](#1966)) ([828e460](828e460)) * korean detection ([#2005](#2005)) ([362dab8](362dab8)) * Kubo agent text to link via ReleaseLink [#2010](#2010) ([#2011](#2011)) ([3d04988](3d04988)) * nodejs readme badges ([#1985](#1985)) ([a9e661b](a9e661b)) * remove web ui version and keep revision ([#2000](#2000)) ([42ed78d](42ed78d)) * resolve issues with automated releases ([#1974](#1974)) ([9a7cfad](9a7cfad)) ### Trivial Changes * add missing classnames dependency ([#1977](#1977)) ([c4216b8](c4216b8)) * **deps:** update react-scripts ([#1969](#1969)) ([136b260](136b260)) * pull transifex translations ([#1996](#1996)) ([0de4267](0de4267)) * Pull transifex translations ([#2003](#2003)) ([cc51b15](cc51b15)) * **readme:** NodeJS version support info ([#1986](#1986)) ([829450d](829450d)) * **readme:** update release steps ([#1963](#1963)) ([c5b4822](c5b4822)) * Update .github/workflows/stale.yml [skip ci] ([f15818d](f15818d)) * update storybook and stories ([#2007](#2007)) ([83ceac1](83ceac1)), closes [/github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack-5](https://github.com/ipfs//github.com/storybookjs/storybook/blob/next/MIGRATION.md/issues/webpack-5)

ipfs-gui-bot · 2022-09-09T23:34:13Z

🎉 This PR is included in version 2.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

hacdias and others added 30 commits September 20, 2021 15:41

wip: bootstrap settings ipns keys

7910e5f

wip: add table and generate modal

d126d43

wip: rename working

66dda15

wip: remove working

28c7b85

wip: working rename, remove and generation

71b02cc

show available keys through link

e67ca16

wip: publish from files

8fa8d8c

publishing works from files page

ccf8ed9

fix: disable button when no option is selected

bedc063

Merge branch 'main' into feat/1482-settings

14b2db6

style: IPNS copy tweaks on settings screen

55064f0

docs: suggest backing up IPNS key before removal

3344487

style: ipns publishing modal tweaks

1b65411

style: publish to ipns

44ace78

Needs to be eyeballed by a native speaker, but this wins the google search result count for now.

chore: go-ipfs 0.10.0

91e0df4

test(e2e): ipns keys on settings screen

ab4901e

chore: @playwright/test v1.16.3

71aefa7

refactor(e2e): remove waitForText helper

3b54406

It was useful in puppeteer, but now we use playwright which solves waiting logic way better via text selectors

use defaults for ipfs.key.gen

7dcfc1b

feat: wait for publishing

326b892

test(ipns): confirm IPNS record was published

f99120e

docs: ipns sharing prompt

67f51a8

This is basic copy that encourages sharing gateway link + disclaimer about the need for keeping node online once a day.

add progress bar

9b65fd7

remove console.log

84d5a8c

extract progress calculation

227de8b

feat: adjusted guess for progressbar

8ff5764

Most of fake/guessed progress bars overshoot, as it is better UX to "finishe sooner than be stuck at 100%" This change makes expectation always bit bigger than the rolling average between last two times.

feat: css animations for progress bar

18717fd

Merge branch 'feat/1482-settings' of https://github.com/ipfs/ipfs-webui…

b581062

… into feat/1482-settings

fix: bar does not go over the limits

857bdf5

Merge branch 'main' into feat/1482-settings

ae51379

hacdias temporarily deployed to Deploy July 10, 2022 07:04 Inactive

chore: update package lock with right versions

b062406

hacdias temporarily deployed to Deploy July 20, 2022 08:53 Inactive

lidel self-assigned this Jul 25, 2022

Merge main into feat/1482-settings

dbcad82

lidel temporarily deployed to Deploy July 25, 2022 18:36 Inactive

lidel removed the status/blocked Unable to be worked further until needs are met label Jul 25, 2022

docs(ipns): point at Settings screen

9c90a41

When someone opens IPNS publishing they now get a hint that more info and key management can be found in Settings

lidel temporarily deployed to Deploy July 25, 2022 19:30 Inactive

test(e2e): ipns key removal via Settings

11d8c3a

lidel temporarily deployed to Deploy July 25, 2022 20:22 Inactive

lidel approved these changes Jul 25, 2022

View reviewed changes

juliaxbow reviewed Jul 25, 2022

View reviewed changes

refactor: update english keys

ded8966

hacdias temporarily deployed to Deploy July 26, 2022 07:39 Inactive

lidel merged commit 4ff4939 into main Jul 26, 2022

lidel deleted the feat/1482-settings branch July 26, 2022 12:22

lidel mentioned this pull request Jul 26, 2022

Improve UX of IPNS publishing #1993

Closed

ipfs-gui-bot added the released label Sep 9, 2022

lidel mentioned this pull request Dec 9, 2022

Ability to publish with IPNS ipfs/ipfs-desktop#2084

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: IPNS Publishing #1973

feat: IPNS Publishing #1973

hacdias commented Jul 10, 2022 •

edited

Loading

SgtPooki commented Jul 18, 2022

SgtPooki commented Jul 18, 2022 •

edited

Loading

hacdias commented Jul 20, 2022

lidel commented Jul 25, 2022

lidel left a comment

juliaxbow left a comment

TheDiscordian commented Jul 25, 2022

hacdias commented Jul 26, 2022

lidel commented Jul 26, 2022 •

edited

Loading

ipfs-gui-bot commented Sep 9, 2022

feat: IPNS Publishing #1973

feat: IPNS Publishing #1973

Conversation

hacdias commented Jul 10, 2022 • edited Loading

Generate New Key

Publishing Keys Settings Menu

Drop Down

Publish

SgtPooki commented Jul 18, 2022

SgtPooki commented Jul 18, 2022 • edited Loading

hacdias commented Jul 20, 2022

lidel commented Jul 25, 2022

lidel left a comment

Choose a reason for hiding this comment

juliaxbow left a comment

Choose a reason for hiding this comment

TheDiscordian commented Jul 25, 2022

hacdias commented Jul 26, 2022

lidel commented Jul 26, 2022 • edited Loading

ipfs-gui-bot commented Sep 9, 2022

hacdias commented Jul 10, 2022 •

edited

Loading

SgtPooki commented Jul 18, 2022 •

edited

Loading

lidel commented Jul 26, 2022 •

edited

Loading