Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added classnames to package.json #1977

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Conversation

JustinTime42
Copy link
Contributor

Added classnames to package.json to resolve this issue #1976

@welcome
Copy link

welcome bot commented Jul 15, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@SgtPooki SgtPooki self-assigned this Jul 18, 2022
@SgtPooki SgtPooki added P0 Critical: Tackled by core team ASAP P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked need/maintainer-input Needs input from the current maintainer(s) and removed P0 Critical: Tackled by core team ASAP labels Jul 18, 2022
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the latest version of main, checking dependencies with depcheck shows the following:

> npx --yes depcheck
(node:34078) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /Users/sgtpooki/code/work/protocol.ai/ipfs/webui/node_modules/@playwright/test/package.json.
Update this package.json to use a subpath pattern like "./*".
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:34078) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /Users/sgtpooki/code/work/protocol.ai/ipfs/webui/node_modules/playwright-chromium/package.json.
Update this package.json to use a subpath pattern like "./*".
Unused dependencies
* @tableflip/react-inspector
* react-loadable
* react-router-dom
* react-spring
* react-test-renderer
* simplify-number
* video-extensions
* window.ipfs-fallback
Unused devDependencies
* @mapbox/node-pre-gyp
* @semantic-release/changelog
* @semantic-release/commit-analyzer
* @semantic-release/git
* @semantic-release/github
* @semantic-release/npm
* @semantic-release/release-notes-generator
* @storybook/addons
* @types/node
* dnslink-dnsimple
* fake-indexeddb
* http-server
* is-pull-stream
* playwright-chromium
* semantic-release
Missing dependencies
* eslint-config-react-app: ./.eslintrc.js
* @typescript-eslint/parser: ./.eslintrc.js
* eslint-plugin-flowtype: ./.eslintrc.js
* eslint-plugin-react-hooks: ./.eslintrc.js
* @typescript-eslint/eslint-plugin: ./.eslintrc.js
* eslint-plugin-react: ./.eslintrc.js
* expect-playwright: ./test/e2e/setup/global-after-env.js
* classnames: ./src/peers/PeersTable/PeersTable.js

@SgtPooki SgtPooki self-requested a review July 20, 2022 17:46
@SgtPooki
Copy link
Member

I still have some checks I want to do against the version we're installing, and the multiple versions listed in package-lock

@SgtPooki
Copy link
Member

> npx --yes npm-check
classnames  - 😟  PKG ERR!  - Not in the package.json. Found in: /src/peers/PeersTable/PeersTable.js, /src/navigation/NavBar.js, /src/files/selected-actions/SelectedActions.js, /src/files/header/Header.js, /src/files/files-list/FilesList.js, /src/files/file/File.js, /src/files/breadcrumbs/Breadcrumbs.js, /src/components/shell/Shell.js, /src/components/popover/Popover.js, /src/components/pinning-manager/pinning-manager-service-modal/PinningManagerServiceModal.js, /src/components/is-not-connected/IsNotConnected.js, /src/components/context-menu/ContextMenu.js, /src/components/context-menu/ContextMenuItem.js, /src/components/button/Button.js

@SgtPooki SgtPooki removed the need/maintainer-input Needs input from the current maintainer(s) label Jul 20, 2022
@SgtPooki SgtPooki merged commit c4216b8 into ipfs:main Jul 20, 2022
ipfs-gui-bot pushed a commit that referenced this pull request Sep 9, 2022
## [2.18.0](v2.17.3...v2.18.0) (2022-09-09)

 CID `bafybeidb5eryh72zajiokdggzo7yct2d6hhcflncji5im2y5w26uuygdsm`

 ---

### Features

* IPNS Publishing ([#1973](#1973)) ([4ff4939](4ff4939))
* ux improvements to publish modal ([#1998](#1998)) ([ea4f632](ea4f632))

### Bug Fixes

* **ci:** parsing "ipfs-cluster-ctl peers ls" output ([#1966](#1966)) ([828e460](828e460))
* korean detection ([#2005](#2005)) ([362dab8](362dab8))
* Kubo agent text to link via ReleaseLink [#2010](#2010) ([#2011](#2011)) ([3d04988](3d04988))
* nodejs readme badges ([#1985](#1985)) ([a9e661b](a9e661b))
* remove web ui version and keep revision ([#2000](#2000)) ([42ed78d](42ed78d))
* resolve issues with automated releases  ([#1974](#1974)) ([9a7cfad](9a7cfad))

### Trivial Changes

* add missing classnames dependency ([#1977](#1977)) ([c4216b8](c4216b8))
* **deps:** update react-scripts ([#1969](#1969)) ([136b260](136b260))
* pull transifex translations ([#1996](#1996)) ([0de4267](0de4267))
* Pull transifex translations ([#2003](#2003)) ([cc51b15](cc51b15))
* **readme:** NodeJS version support info ([#1986](#1986)) ([829450d](829450d))
* **readme:** update release steps ([#1963](#1963)) ([c5b4822](c5b4822))
* Update .github/workflows/stale.yml [skip ci] ([f15818d](f15818d))
* update storybook and stories ([#2007](#2007)) ([83ceac1](83ceac1)), closes [/github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack-5](https://github.com/ipfs//github.com/storybookjs/storybook/blob/next/MIGRATION.md/issues/webpack-5)
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 2.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High: Likely tackled by core team if no one steps up released status/ready Ready to be worked
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants