-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ux improvements to publish modal #1998
Conversation
cc @juliaxbow for 👀 |
Minor changes to the success state after clicking the copy icon:
|
I addressed @juliaxbow's comments and removed the 'Cancel' button after publishing as it does not do anything different than 'Done'. Screen.Recording.2022-08-08.at.11.42.29.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
## [2.18.0](v2.17.3...v2.18.0) (2022-09-09) CID `bafybeidb5eryh72zajiokdggzo7yct2d6hhcflncji5im2y5w26uuygdsm` --- ### Features * IPNS Publishing ([#1973](#1973)) ([4ff4939](4ff4939)) * ux improvements to publish modal ([#1998](#1998)) ([ea4f632](ea4f632)) ### Bug Fixes * **ci:** parsing "ipfs-cluster-ctl peers ls" output ([#1966](#1966)) ([828e460](828e460)) * korean detection ([#2005](#2005)) ([362dab8](362dab8)) * Kubo agent text to link via ReleaseLink [#2010](#2010) ([#2011](#2011)) ([3d04988](3d04988)) * nodejs readme badges ([#1985](#1985)) ([a9e661b](a9e661b)) * remove web ui version and keep revision ([#2000](#2000)) ([42ed78d](42ed78d)) * resolve issues with automated releases ([#1974](#1974)) ([9a7cfad](9a7cfad)) ### Trivial Changes * add missing classnames dependency ([#1977](#1977)) ([c4216b8](c4216b8)) * **deps:** update react-scripts ([#1969](#1969)) ([136b260](136b260)) * pull transifex translations ([#1996](#1996)) ([0de4267](0de4267)) * Pull transifex translations ([#2003](#2003)) ([cc51b15](cc51b15)) * **readme:** NodeJS version support info ([#1986](#1986)) ([829450d](829450d)) * **readme:** update release steps ([#1963](#1963)) ([c5b4822](c5b4822)) * Update .github/workflows/stale.yml [skip ci] ([f15818d](f15818d)) * update storybook and stories ([#2007](#2007)) ([83ceac1](83ceac1)), closes [/github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack-5](https://github.com/ipfs//github.com/storybookjs/storybook/blob/next/MIGRATION.md/issues/webpack-5)
🎉 This PR is included in version 2.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #1993
When it finishes publishing:
After clicking:
Then the icon goes back to normal after 2 seconds.