Improved dry run and execution log for topics and schemas #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split SyncTopicAction into separate actions for the different parts: create topic, update config and update schema reg
Create a topic config update plan for the UpdateTopicConfigAction. And let the adminClient only update according to the plan.
This reverts commit 00bc474.
Rename methods and ManagerOfThings
Log details on the actual topic config changes that will be done. Also fixed logic for detecting new configs added.
Test logic for detecting new, updated and removed topic configs.
…sable on dind on Windows
…e design around TopologyAclBinding builders, the Action concept and managers for adding actions to the ExecutionPlan.
…aised (#386) * ammend wrong state initialization in the kafka backend * terminate jvm if there is an execution
… the reverse of the creation (#392) * in ksql artefact manager, compile the list of artefacts to be orders in reverse order as sorted before this way tables will go first and then streams * add sample example test for ksql create and delete with dependencies
* use julie.instance.id in case group.id is not defined for the kafka backend * make default variable as consumer group id for kafka backend consumer, by default named julieops, if not it can be configured via property file or env var * ammend kafka tests, not to use same group.id, so consumption is done back from beginiing
…corrupted. (#396) * strengh the kafka backend resilence model * add example props for kafka as backend * add call to create julieops internal topic * update simplified topology file * add kafka config topic as defult internal topic if using kafka backend * Revert "add kafka config topic as defult internal topic if using kafka backend" This reverts commit 2f84410. * ammend tests
…e type) (#398) * fix delete problem on resource used from the rbac api * ammend localization of the resourceType capitalization as not all rbac resources follow this pattern
ammend criteria for time fix in kafka backend consumer
* Resolve #25: Quotas implementation, only quotas based in user principal * Add doc usage of quotas Co-authored-by: Pere Urbón <purbon@users.noreply.github.com> Co-authored-by: Marcos Martinez Cedillo <marcos.martinez@orangebank.es>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take over from #383 to fix merge conflict.
Thanks again for all your contributions @akselh and @sverrehu !! all your help is very much appreciated.
close #295