[release-v1.43] Use docker hub fedora #2662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Du <yadu@redhat.com> Co-authored-by: Yan Du <yadu@redhat.com>
* Cleanup DataImportCron jobs on deletion Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * CR fixes Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Func test fixes Signed-off-by: Arnon Gilboa <agilboa@redhat.com> Co-authored-by: Arnon Gilboa <agilboa@redhat.com>
…bevirt#2108) We want to silence the KubePersistentVolumeFillingUp for all our PVCs that hold virtual machine disks, since these disks consume the entire PVC by design. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Co-authored-by: Alex Kalenyuk <akalenyu@redhat.com>
This one was missed in kubevirt#2018, we want to maintain its label values on update as well. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Co-authored-by: Alex Kalenyuk <akalenyu@redhat.com>
…ubevirt#2101) * Remove tag from DataImportCron registry source URL There are cases when DataImportCron registry source URL contains tag referring a specific version. We use this tagged URL when polling for source updates, but on import we would like to remove the tag as we use a specific sha256. E.g. for docker://quay.io/containerdisks/centos:8.4 the :8.4 tag will be removed. Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Use Docker reference parsing Signed-off-by: Arnon Gilboa <agilboa@redhat.com> Co-authored-by: Arnon Gilboa <agilboa@redhat.com>
The following labels should be set by the operator that creates the resource, and not by the DataImportCron controller, otherwise it may result an unnecessary reconciliation and a race-condition. app.kubernetes.io/component app.kubernetes.io/managed-by Signed-off-by: Arnon Gilboa <agilboa@redhat.com> Co-authored-by: Arnon Gilboa <agilboa@redhat.com>
…bevirt#2114) * Delete CRDs & check finalizers in operator delete reconcileDeleteControllerDeployment deletes the CRDs of DataImportCron and DataVolume, and returns error if any DIC/DV has a finalizer. It will get retried and controller will eventually remove the finalizers. Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Fix error handling Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Add destructive operator test Signed-off-by: Arnon Gilboa <agilboa@redhat.com> Co-authored-by: Arnon Gilboa <agilboa@redhat.com>
…irt#2112) * Update DataSource Ready condition on DV update Added the DataSource controller a DV watch, so whenever a DataSource referred DV/PVC is created/updated/deleted, the DataSource Ready status condition is updated accordingly. Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Use field indexer for DV watch Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * CR fixes Signed-off-by: Arnon Gilboa <agilboa@redhat.com> Co-authored-by: Arnon Gilboa <agilboa@redhat.com>
Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
) * Add optional VDDK initImageURL field. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Pass VDDK image URL through to PVC annotation. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Unit tests for per-DV VDDK image URL. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Functional test for VDDK initImageURL field. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Update documentation for VDDK initImageURL. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Fix lint error. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Check for absence of AwaitingVDDK in unit test. Signed-off-by: Matthew Arnold <marnold@redhat.com> Co-authored-by: Matthew Arnold <marnold@redhat.com>
* Fix error message to be without trace Pass the function only the err without the wraping back trace which is too long and causes the message to overflow and not show the specific error. Fixes: BZ#2000661 Signed-off-by: Shelly Kagan <skagan@redhat.com> * Update expected error msg according to new change The Error msg will be longer with other messages in between: "Unable to process data: Unable to transfer source data to target directory: unable to untar files from endpoint: exit status 2" Signed-off-by: Shelly Kagan <skagan@redhat.com> Co-authored-by: Shelly Kagan <skagan@redhat.com>
…#2125) For some reason curling localhost stopped working for us after kubevirt/project-infra#1616, So let's change to 127.0.0.1. Does not reproduce using on my machine when using a prow mimic: https://github.com/kubernetes/test-infra under `prow/cmd/phaino`. Only reproduces on the real prow env. thanks dhiller. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Co-authored-by: Alex Kalenyuk <akalenyu@redhat.com>
…2127) * Add DataImportCron ImageStream tag support Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Fix storageClass possible nil deref Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Change DataSource indexer key separator Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Add DataImportCron ImageStream tag utest Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * CR fixes Signed-off-by: Arnon Gilboa <agilboa@redhat.com> Co-authored-by: Arnon Gilboa <agilboa@redhat.com>
Every once in a while the rejection message by kubectl is changed and it causes failures in the test. This commit makes the check less strict so it looks for the message output by our webhook, not the extra kubernetes messsage as well. Signed-off-by: Alexander Wels <awels@redhat.com> Co-authored-by: Alexander Wels <awels@redhat.com>
* Fix CRDs deletion in operator deletion Also check DataImportCron CRD has no DeletionTimestamp before adding a finalizer Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * CR fixes Signed-off-by: Arnon Gilboa <agilboa@redhat.com> Co-authored-by: Arnon Gilboa <agilboa@redhat.com>
…t#2137) * Set htpp(s)_proxy to lower case env variable CURL used by nbdkit doesn't read upper case http(s)_proxy environment variables, and thus was not using the proxy. Changed the variable to be lower case. Added a significant number of tests to test many more variations of using a proxy. Also added https + auth endpoint to the file-host container, so we can test https + auth with the proxy. Added https endpoint to proxy, so we can test an https proxy. Cleaned up some of the error handling in the import controller for the proxy, in particular if a trustedCAProxy is defined. Fixed some of the cluster wide proxy configuration so it works properly inside an openshift cluster. Signed-off-by: Alexander Wels <awels@redhat.com> * Add https proxy support to registry import. Added extra functional tests to test all registry import combinations Signed-off-by: Alexander Wels <awels@redhat.com> * Fixed some tests to work better in Open Shift. Signed-off-by: Alexander Wels <awels@redhat.com> Co-authored-by: Alexander Wels <awels@redhat.com>
…sing Storage API fails (kubevirt#2134) * Update clone size validation logic The case with DV using spec.storage API needs more complex validation that will be added in the clone controller. The API webhook validation for that case is removed. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Improve DV phase failure message in tests Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Add test and warning event for clone size During clone check if actual requested size on source volume is bigger than target requested size and emit an event to notify user about situation. Actual size on filesystem is lower that requested, because of possible filesystem overhead. When using storage API the overhead will be applied on target. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Code Review cleanup - Removing debug logs Removed some garbage left after troubleshooting. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Move fn GetUsableSpace to common utils Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Adapt code to release 1.43 There is no expectEvent in older code. Needed to change to verifyEvent. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
Update DataSource only if it has a DataImportCron label Signed-off-by: Arnon Gilboa <agilboa@redhat.com> Co-authored-by: Arnon Gilboa <agilboa@redhat.com>
* Fix failing imageio test Always enable scratch space for imageio imports. Signed-off-by: Alexander Wels <awels@redhat.com> * Only always enable scratch space with warm migration imports. Signed-off-by: Alexander Wels <awels@redhat.com> Co-authored-by: Alexander Wels <awels@redhat.com>
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Signed-off-by: Alexander Wels <awels@redhat.com>
…rt#2171) We consistently fail on the check that `info.VirtualSize >= info.ActualSize` on a real external nfs sever with different block size to what we're using upstream. This happens because qemu-img info gives us the size on disk in ActualSize. For the purpose of sparseness, I believe we are interested in the content size and not the padded size on disk. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Co-authored-by: Alex Kalenyuk <akalenyu@redhat.com>
* Style - formatting Small formatting change to make things easier to read /compare. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Configure filesystem capability for ceph-rbd Some combinations of upload/import require filesystem. Ceph rbd actually supports FS with RWO. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Test Storage capability with archive content Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Extract Rbd method Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> Co-authored-by: Bartosz Rybacki <brybacki@redhat.com>
We pause/resume the MCP on OpenShift clusters to not have to go through node reboots. This is quite expensive AfterEach test, especially because of https://bugzilla.redhat.com/show_bug.cgi?id=2005694. Let's have the testing infrastructure be responsible for this and preconfigure in setup/teardown scripts instead. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Co-authored-by: Alex Kalenyuk <akalenyu@redhat.com>
… validation (kubevirt#2198) * Create a test for an overhead bug This image size and filesystem overhead combination was experimentally determined to reproduce bz#2064936 in CI when using ceph/rbd with a Filesystem mode PV since the filesystem capacity will be constrained by the PVC request size. Below is the problem it tries to recreate: When validating whether an image will fit into a PV we compare the image's virtual size to the filesystem's reported available space to guage whether it will fit. The current calculation reduces the apparent available space by the configured filesystem overhead value but the overhead is already (mostly) factored into the result of Statfs. This causes the check to fail for PVCs that are just large enough to accommodate an image plus overhead (ie. when using the DataVolume Storage API with filesystem PVs with capacity constrained by the PVC storage request size). This was not caught in testing because HPP does not have capacity constrained PVs and we are typically testing block volumes in the ceph lanes. It can be triggered in our CI by allocating a Filesystem PV on ceph-rbd storage because these volumes are capacity constrained and subject to filesystem overhead. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Fix a target pvc validation bug Corrects the validation logic for target volume. Below description of the original problem: When validating whether an image will fit into a PV we compare the image's virtual size to the filesystem's reported available space to guage whether it will fit. The current calculation reduces the apparent available space by the configured filesystem overhead value but the overhead is already (mostly) factored into the result of Statfs. This causes the check to fail for PVCs that are just large enough to accommodate an image plus overhead (ie. when using the DataVolume Storage API with filesystem PVs with capacity constrained by the PVC storage request size). This was not caught in testing because HPP does not have capacity constrained PVs and we are typically testing block volumes in the ceph lanes. It can be triggered in our CI by allocating a Filesystem PV on ceph-rbd storage because these volumes are capacity constrained and subject to filesystem overhead. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Improve the warning message Removed redundant and misleading part about pvc size and update the simplification Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Remove useless test The test checks that the validation logic takes fs Overhead into account. New validation logic does not check fs overhead. So test is no longer relevant. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> Co-authored-by: Bartosz Rybacki <brybacki@redhat.com>
Manual backport of kubevirt#2196 * Reconcile DVs waiting for default SC Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * CR fixes Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
…bevirt#2149) (kubevirt#2159) As of now OpenShift UI will not display the runbook URL field for our alerts (docs and google will though), so let's make sure we provide a better entry point by being verbose in what is actually visible to the user. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
…AfterCompletion. (kubevirt#2214) * Append checkpoint ID to multi-stage importer pods. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Ignore completed pods for multi-stage imports. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Reset current import pod when checkpoint is done. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Don't prevent pod deletion for scratch space. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Only ignore pod when retainAfterCompletion is set. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Fix data volume unit tests. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Tests for checkpoint suffix and completed pods. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Test for retained pods exiting for scratch space. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Add functional test for retaining multistage pods. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Clean up lint error. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Remove scratch handling that is fixed elsewhere. This is part of shouldDeletePod now. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Add unit tests for long PVC/checkpoint names. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Match retainAfterCompletion test to description. Signed-off-by: Matthew Arnold <marnold@redhat.com> Co-authored-by: Matthew Arnold <marnold@redhat.com>
… fix quota test (kubevirt#2210) * Include namespace of upgrade testing manifests in yaml Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * Don't back out until we verify quota status is set following us POSTing it Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Co-authored-by: Alex Kalenyuk <akalenyu@redhat.com>
Update github.com/containers/image/v5 so that we can pull github.com/opencontainers/image-spec >= 1.0.2. This version contains a security-related fix: GHSA-77vh-xpmg-72qh Signed-off-by: Maya Rashish <mrashish@redhat.com> Co-authored-by: Maya Rashish <mrashish@redhat.com>
Noticed the consts were strings instead of the right types this changes the type to the right type and modifies the usage to not have to cast to the right type all over the place. Signed-off-by: Alexander Wels <awels@redhat.com> Co-authored-by: Alexander Wels <awels@redhat.com>
* Fix smart clone request size update In case the pvc got an actual size as the expected size there wasn't an update of the pvc spec with the actual user request size, which left the pvc spec with a smaller size then the user requested(the data size). This caused a discrepancy when trying to restore such pvc, which restored a pvc with the small size instead of the user request size. Signed-off-by: Shelly Kagan <skagan@redhat.com> * review fixes Signed-off-by: Shelly Kagan <skagan@redhat.com> * cherry pick fix Signed-off-by: Shelly Kagan <skagan@redhat.com> * Fix smart clone update request size condition Signed-off-by: Shelly Kagan <skagan@redhat.com>
…t#2304) Manual backport of kubevirt#2294 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Previously, when a DataVolume was Reconciled then CDI created PVC regardless of prePopulated annotation. There is a possibility that DataVolume and PVC pair is being restored or moved from other cluster. When DataVolume is marked as prePopulated, the CDI should not try to populate it. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> Co-authored-by: Bartosz Rybacki <brybacki@redhat.com>
…evirt#2324) * Extract the clone logic for reconcile This change only extracts the code branch that handles the clone. The main idea is to divide the reconcile loop into parts doing import, upload and clone. This makes code easier to read and understand. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Cleanup handling not existing PVC Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> Co-authored-by: Bartosz Rybacki <brybacki@redhat.com>
* Test handling of populated PVC Populated PVC created from clone operation should not start any CDI actions. It can only update DV status. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Handle prepopulated pvc with network clone Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Handle prepopulated PVC for Smart and CSI clone Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> Co-authored-by: Bartosz Rybacki <brybacki@redhat.com>
…evirt#2321) Sometimes we see that ticket is not there (thx awels), we might want to try a few times before giving up. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
* Test: Clone fs to block fails on size validation When requesting size `X` with filesystem volume mode and storage api the size is increased for the fs overhead. When trying to clone to block using the same size `X` the clone fails because the target is smaller than source. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Improve size validation for clone Skip size validation for filesystem in webhook and include filesystem overhead when doing the validation in controller. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> # Conflicts: # pkg/controller/clone-controller.go # pkg/controller/datavolume-controller.go # pkg/controller/util.go * Correct unit test with fs overhead Signed-off-by: Bartosz Rybacki <brybacki@redhat.com> * Restore CDI Config after each clone test Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
Signed-off-by: Alexander Wels <awels@redhat.com>
…c already populated (kubevirt#2405) * Allow clone when source pvc doesnt exist if target is populated Signed-off-by: Shelly Kagan <skagan@redhat.com> * Adjust code to handle a clone of missing source PVC In case the target pvc exists and populated we should allow the clone to complete successfully without doing anything. Adjust the code and add a test for that case. Signed-off-by: Shelly Kagan <skagan@redhat.com> Signed-off-by: Shelly Kagan <skagan@redhat.com>
…arget pvc already populated (kubevirt#2405)" This reverts commit 4e7114d. Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
Revert "[release-v1.43] Manual fix for clone without source pvc but t…
…vc but target pvc already populated (kubevirt#2405)"" (kubevirt#2412) This reverts commit 4e20397. Signed-off-by: Michael Henriksen <mhenriks@redhat.com> Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
…not cleaning up (kubevirt#2415) * fix issue kubevirt#2323: Cross namespace smart clone leaving tmp PVC and ObjectTransfer around Signed-off-by: Michael Henriksen <mhenriks@redhat.com> * wait for objecttransfers to be cleaned up in clone tests Signed-off-by: Michael Henriksen <mhenriks@redhat.com> * attempt to address test failures Signed-off-by: Michael Henriksen <mhenriks@redhat.com> * move cross namespace cleanup code Signed-off-by: Michael Henriksen <mhenriks@redhat.com> * move cleanup transfer call until after dataSource is resolved Signed-off-by: Michael Henriksen <mhenriks@redhat.com> * fix tests Signed-off-by: Michael Henriksen <mhenriks@redhat.com> Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
…rt#2423) Currently we'll back out on various errors instead of waiting for proper cleanup, which results in flakiness. Let's try to give any error a decent chance to go away. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Co-authored-by: Alex Kalenyuk <akalenyu@redhat.com>
* Dump some information if the upgrade testing objects are not ready in time. Signed-off-by: Alexander Wels <awels@redhat.com> * modified cherry pick of db21765 Signed-off-by: Michael Henriksen <mhenriks@redhat.com> Signed-off-by: Alexander Wels <awels@redhat.com> Signed-off-by: Michael Henriksen <mhenriks@redhat.com> Co-authored-by: Alexander Wels <awels@redhat.com>
…#2494) Signed-off-by: Michael Henriksen <mhenriks@redhat.com> Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
Signed-off-by: Alexander Wels <awels@redhat.com>
|
@awels: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubevirt-bot
added
dco-signoff: no
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
kubevirt-bot
added
the
needs-rebase
|
@awels: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@awels: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Quay removed the fedora 33 image, so switch to dockerhub to get it for the few times we need to update 1.43
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: