Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-integers passed as connection limits #1571

Closed
maschad opened this issue Jan 30, 2023 · 1 comment
Closed

Handle non-integers passed as connection limits #1571

maschad opened this issue Jan 30, 2023 · 1 comment
Labels
need/triage Needs initial labeling and prioritization

Comments

@maschad
Copy link
Member

maschad commented Jan 30, 2023

If maxConnections is passed in as a float, this will result in disconnecting all peers due to this strict equality check.

This may happen unintentionally if maxConnections is set dynamically.

Related: #1570
@maschad maschad added the need/triage Needs initial labeling and prioritization label Jan 30, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 30, 2023
@maschad
fix: Handle non-integers passed as connection limits (libp2p#1571)
4e01ede
@maschad maschad mentioned this issue Jan 30, 2023
Closed
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 31, 2023
@maschad
fix: throw error for non-integer connection limits (libp2p#1571)
81b5154
@maschad
Copy link
Member Author

maschad commented Feb 10, 2023

Closing in favour of #1573

@maschad maschad closed this as completed Feb 10, 2023
@wemeetagain wemeetagain mentioned this issue Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Handle non-integers passed as connection limits maschad/js-libp2p
1 participant
@maschad