Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration validation #1573

Closed
achingbrain opened this issue Feb 1, 2023 · 0 comments · Fixed by #1778 · May be fixed by #2133
Closed

Configuration validation #1573

achingbrain opened this issue Feb 1, 2023 · 0 comments · Fixed by #1778 · May be fixed by #2133
Assignees
@maschad
Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature

Comments

@achingbrain
Copy link
Member

We don't perform much in the way of validation on loaded libp2p config but we really should.

Ideally each module parsing it's config would use something like superstruct to validate at creation time and fail fast with good feedback to the user as to how they can fix their broken config.

This should negate the need for PRs like #1572 as the config would have been validated in src/config.ts already.
@achingbrain achingbrain added need/triage Needs initial labeling and prioritization kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding exp/intermediate Prior experience is likely helpful and removed need/triage Needs initial labeling and prioritization labels Feb 1, 2023
@maschad maschad self-assigned this Feb 6, 2023
This was referenced Feb 7, 2023
Closed
Closed
@p-shahi p-shahi removed the need/analysis Needs further analysis before proceeding label Feb 14, 2023
@achingbrain achingbrain mentioned this issue Feb 14, 2023
Closed
This was referenced Apr 3, 2023
Closed
Merged
@achingbrain achingbrain mentioned this issue May 16, 2023
Open
@maschad maschad mentioned this issue May 18, 2023
Closed
maschad added a commit to maschad/js-libp2p that referenced this issue May 29, 2023
@maschad
refactor: added addresses config validation (libp2p#1573)
71490db
@maschad maschad mentioned this issue May 29, 2023
Merged
maschad added a commit to maschad/js-libp2p that referenced this issue Jul 3, 2023
@maschad
feat: added default announce filter (libp2p#1573)
73f9fc7
maschad added a commit to maschad/js-libp2p that referenced this issue Jul 4, 2023
@maschad
feat: refactored config to validate before returning service (libp2p#…
893e068 
…1573)
maschad added a commit to maschad/js-libp2p that referenced this issue Jul 5, 2023
@maschad
test: refactor tests + updated config (libp2p#1573)
f86432a
maschad added a commit to maschad/js-libp2p that referenced this issue Jul 5, 2023
@maschad
chore: linting (libp2p#1573)
c3ed878
maschad added a commit to maschad/js-libp2p that referenced this issue Jul 21, 2023
@maschad
feat: updated config validation for identify and circuit relay (libp2…
6bd7bec 
…p#1573)
@maschad maschad mentioned this issue Jul 27, 2023
Closed
maschad added a commit to maschad/js-libp2p that referenced this issue Aug 20, 2023
@maschad
fix: added transient connection default to identify service (libp2p#1573
0d4c8e4 
)
maschad added a commit to maschad/js-libp2p that referenced this issue Aug 21, 2023
@maschad
refactor: Refactored config to be done inside services (libp2p#1573)
a89818a
@achingbrain achingbrain mentioned this issue Oct 6, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maschad maschad

Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
3 participants
@achingbrain @maschad @p-shahi