fix: compare unsanitized number using gte

[wemeetagain]

If maxConnections is passed in as a float, this will result in disconnecting all peers due to this strict equality check.

This may happen unintentionally if maxConnections is set dynamically.

This is a patch to avoid this unfortunate failure mode.

Likely more thought should go into a systematic approach to handling these situations.

[maschad]

I can't conceptualize a fraction of a connection so I would suggest we convert any value set as maxConnections to a positive integer value internally - using something like Math.trunc - before we perform operations with that value.

[maschad]

I opened up #1572 in favour of this solution

[wemeetagain]

Yea opened this PR mainly for discussion.

I think ideally we can/should validate user options in some more systematic way. Not sure about coersing user values, that could cause some confusion. Perhaps better to just throw when they are invalid.

[maschad]

I think ideally we can/should validate user options in some more systematic way. Not sure about coersing user values, that could cause some confusion. Perhaps better to just throw when they are invalid.

Agreed. That was also the suggestion made here

[achingbrain]

Closing as we are going to implement more comprehensive config validation - #1573