Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle non-integers passed as connection limits #1572

Closed
wants to merge 1 commit into from
Closed

fix: Handle non-integers passed as connection limits #1572

wants to merge 1 commit into from

Conversation

maschad
Copy link
Member

@maschad maschad commented Jan 30, 2023

Closes #1571

@maschad maschad mentioned this pull request Jan 30, 2023
Closed
@maschad maschad changed the title fix: Handle non-integers passed as connection limits (#1571) fix: Handle non-integers passed as connection limits Jan 30, 2023
achingbrain
achingbrain requested changes Jan 30, 2023
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config is invalid - it should throw instead of trying to convert floats to ints.

@maschad maschad force-pushed the fix/update-max-connections-int branch from 4e01ede to 81b5154 Compare January 31, 2023 02:08
@achingbrain achingbrain mentioned this pull request Feb 1, 2023
Closed
@maschad
Copy link
Member Author

maschad commented Feb 7, 2023

Closing this in light of #1573

@maschad maschad closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle non-integers passed as connection limits
2 participants
@maschad @achingbrain