test UI, fix bugs #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: check err before use schedule and duration Signed-off-by: daengdaengLee <gunho1020@gmail.com> * test: add tests for invalid schedule and duration Signed-off-by: daengdaengLee <gunho1020@gmail.com> * feat: change to return error when sync window is invalid Signed-off-by: daengdaengLee <gunho1020@gmail.com> * fix: use assert.Error or assert.NoError Signed-off-by: daengdaengLee <gunho1020@gmail.com> * fix: use require instead of assert Signed-off-by: daengdaengLee <gunho1020@gmail.com> --------- Signed-off-by: daengdaengLee <gunho1020@gmail.com>
Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com>
argoproj#20363) Bumps [github.com/bmatcuk/doublestar/v4](https://github.com/bmatcuk/doublestar) from 4.6.1 to 4.7.1. - [Release notes](https://github.com/bmatcuk/doublestar/releases) - [Commits](bmatcuk/doublestar@v4.6.1...v4.7.1) --- updated-dependencies: - dependency-name: github.com/bmatcuk/doublestar/v4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: simplify 'get repo' API implementation Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * import order Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…) (argoproj#20337) * docs: feature maturity page for alpha and beta features (argoproj#20336) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * typos Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…rgoproj#20378) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.111.0 to 0.112.0. - [Release notes](https://github.com/xanzy/go-gitlab/releases) - [Changelog](https://github.com/xanzy/go-gitlab/blob/main/releases_test.go) - [Commits](xanzy/go-gitlab@v0.111.0...v0.112.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#20377) Bumps [github.com/redis/go-redis/v9](https://github.com/redis/go-redis) from 9.6.1 to 9.6.2. - [Release notes](https://github.com/redis/go-redis/releases) - [Changelog](https://github.com/redis/go-redis/blob/master/CHANGELOG.md) - [Commits](redis/go-redis@v9.6.1...v9.6.2) --- updated-dependencies: - dependency-name: github.com/redis/go-redis/v9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…s only secrets related to appset (argoproj#20309)
…golang.org/grpc/otelgrpc (argoproj#20376) Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.55.0 to 0.56.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.55.0...zpages/v0.56.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: proxy support Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: proxy support Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: proxy support Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix linter Signed-off-by: pashakostohrys <pavel@codefresh.io> * small improvements Signed-off-by: pashakostohrys <pavel@codefresh.io> * add cluster test Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix linter Signed-off-by: pashakostohrys <pavel@codefresh.io> * change error message Signed-off-by: pashakostohrys <pavel@codefresh.io> * override always will change proxy url Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io>
14 tasks
* fix(controller): change pod status calculate with sidecar Signed-off-by: linghaoSu <linghao.su@daocloud.io> * fix(controller): add restartable sidecar count in total container display Signed-off-by: linghaoSu <linghao.su@daocloud.io> * fix(controller): update info test case conditions Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Linghao Su <slh001@live.cn> * fix(controller): add more test case to cover more conditions Signed-off-by: linghaoSu <linghao.su@daocloud.io> * fix(ui): check is condition exist before for of Signed-off-by: linghaoSu <linghao.su@daocloud.io> --------- Signed-off-by: linghaoSu <linghao.su@daocloud.io> Signed-off-by: Linghao Su <slh001@live.cn> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: linghaoSu <linghao.su@daocloud.io>
…play Signed-off-by: linghaoSu <linghao.su@daocloud.io>
crenshaw-dev
force-pushed
the
fix/sidecar-state-ui
branch
from
6cc0a88
to
e7cd18d
Compare
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> indent Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> fix accidental duplication Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
force-pushed
the
fix/sidecar-state-ui
branch
from
e7cd18d
to
016d5af
Compare
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing with this link to ignore whitespace: https://github.com/linghaoSu/argo-cd/pull/1/files?w=1