This repository has been archived by the owner on Dec 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the microbit library that we will not implement in the simulator (#257) Co-authored-by: Kevin Nguyen <xuannamkevin@gmail.com> Co-authored-by: andreamah <andrea_mah22@hotmail.com>
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vandy Liu <33995460+vandyliu@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Unix Fix for Clue
Fixed group positioning
update readme for clue
* first commit * updated broken test * Fixed spelling error for red_led * Add white leds to refs * wip white leds * Add colors for leds on and off * Modify white led color according to state * Functioning red and white leds * Remove logs * Fix merge conflicts * Format py * Rebase change for cluesimulator.tsx * Reset file to dev version * Restore cluesimulator.tsx with dev version * Make changes for cluesimulator.tsx * Updated led variables Co-authored-by: xnkevinnguyen <xuannamkevin@gmail.com> Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
Fixed issues from bug bash
Co-authored-by: Kevin Nguyen <xuannamkevin@gmail.com> Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
* Update on icons * Make max number of digit dynamic Co-authored-by: Vandy Liu <33995460+vandyliu@users.noreply.github.com>
Added missing field in clue
* Release Note March 10 (#251) release note modification and removed svgs from readme * ubuntu setup fixes (#281) Hotfix for Ubuntu * Serial Monitor Fix (#282) * changed release note for hotfix * Merge staging to dev * Release Note April 15 (#308) * added link to readme * pr feedback * small fix * modifications * removed gestures * adding bbc to microbit Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com> Co-authored-by: Vandy Liu <33995460+vandyliu@users.noreply.github.com> Co-authored-by: andreamah <andrea_mah22@hotmail.com>
xnkevinnguyen
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital,
sagarmanchanda and
smmatte
as code owners
April 9, 2020 22:41
nasadigital
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratz!
…devicesimulator into users/t-xunguy/sync-dev-staging
Sync Dev with Staging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run format
and passes the checks innpm run check