forked from Azure/azure-cli-extensions
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase main #2
Closed
jiec-msft
wants to merge
133
commits into
ninpan-ms:ninpan/job
from
jiec-msft:mason/based-on/ninpan/job
Closed
rebase main #2
jiec-msft
wants to merge
133
commits into
ninpan-ms:ninpan/job
from
jiec-msft:mason/based-on/ninpan/job
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntrolPlaneOnly" (Azure#7277) * Add az fleet updaterun create --upgrade-type parameter "ControlPlaneOnly" * style fixes * Replaced strings with constants. * style fixes round 2
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=131694&view=results Last commit: Azure@4ab5600
…/war/zip file before upload source code; update source to cloud builder to 20240124.1 (Azure#7227)
* Onboard FirmwareAnalysis az cli commands * add recordings * style check * remove extra command * style check * indent * whitespace fix * indent * indent * add service name * test prod fwid * cleanup * change rec * refactor * indent * update readme * add new workspace test cases * update version
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=132128&view=results Last commit: Azure@ec51f09
…urce-control`: Add support for some uncovered commands (Azure#7184) * add support for `automation configuration`, `automation runtime-environment`, `automation source-control` `automation hrwg hrw move` * add support for `automation source-control sync-job` * Fix linter problems * Update api version in recording * Update `HISTORY.rst` * Add examples * Add sync-job update example * Fix style * Update version number
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=132153&view=results Last commit: Azure@498b2d4
…r command with decorator (Azure#7295)
* Add Email Crud Operations using Az Dev Tools * Update HISTORY.rst * update version * update version to 1.8.0b2 * attachments fix * fix visual indent * Update src/communication/azext_communication/azext_metadata.json Co-authored-by: Yu Chen <16348853+jsntcy@users.noreply.github.com> --------- Co-authored-by: Yu Chen <16348853+jsntcy@users.noreply.github.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=132640&view=results Last commit: Azure@a218f7f
…ther per upcoming deprecation (Azure#7302)
* use ref to checkout base branch * add work dispatch
* fix test source code for java * clean up java test code * upgrade spring boot version to fix CVE issue in test case
* Replace guardrails with safeguards * Update help text to include new safeguards level * Fix broken test * Replaced test recordings with safeguards ones * Bump version to new major version since this is a breaking change * Bump version number in setup.py * Replace 'AKS Deployment Safeguards' with 'deployment safeguards' * Use correct version number * Rerun live tests with recordings * Move update back to 2.0.0b1 * Apply suggestions from code review --------- Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=134557&view=results Last commit: Azure@6567c72
…nent (Azure#7216) * initial commit for Java components * add JavaComponentPreviewClient in _clients.py * add "az containerapp env java-component list" * add show and delete command for Java component * use different show and delete method for different java components * refine show and delete logic * add create and update command * refine resource not found error * refine model * update client * add configuration parameter * fix patch command * refine logic * add bind * fix bindname bug * fix comments * fix comments * fix azdev linter error * fix linter error * fix comments * fix comment * fix comment * add test for java component * fix comment * fix bug * update test * refine delete logic * fix comment * fix test error * fix test issue * fix test error * fix test error * fix test error * fix test error * fix comments * fix comment * fix test error test_containerapp_addon_binding_e2e * fix test error - test_containerapp_dev_add_on_binding_customized_keys_e2e * fix test error - test_containerapp_dev_add_on_binding_e2e * fix test error - test_containerapp_dev_add_on_binding_none_client_type * fix test error - test_containerapp_dev_service_binding_customized_keys_e2e * fix test error - test_containerapp_dev_service_binding_customized_keys_yaml_e2e * fix test error - test_containerapp_dev_service_binding_none_client_type * fix test error - test_containerapp_managed_service_binding_e2e * fix test error - test_containerapp_dev_add_on_binding_customized_keys_yaml_e2e * fix test error - test_containerapp_dev_service_binding_e2e * remove binding name validation * update HISTORY.rst * Revert "remove binding name validation" This reverts commit c883393. * add special logic to deal with java component binding name * update unbind logic * refine the model definition * fix test - test_containerapp_java_component * fix test error * fix comments * fix comment * fix comment * fix comment * fix comment * fix comment
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=135060&view=results Last commit: Azure@fafbf72
…cloud flow (Azure#7293) * Add files via upload * Add files via upload * Delete containerapp-0.3.42-py2.py3-none-any.whl * Add files via upload * Delete containerapp-0.3.42-py2.py3-none-any 3.whl * Add files via upload * Delete containerapp-0.3.42-py2.py3-none-any.whl * Delete containerapp-0.3.43-py2.py3-none-any 3.whl * Add files via upload * Delete containerapp-0.3.43-py2.py3-none-any.whl * Add files via upload * Delete containerapp-0.3.43-py2.py3-none-any.whl * Add files via upload * Remove bootstrapped container for source to cloud flow * Delete whl * Add license header * Address PR comments * [Container Apps] Fix issue in Cloud Build when code relies on UTF-8 logs * Removed check for build image starting with default * Fix integration test failures * Fix integration failure * Fix integration test failures * Fix linting errors * Update Release History * Rerun pipeline * Delete recording * Refactor test * Fix integration test * Delete recording and re-record * Re-trigger pipeline * Add live attribute to test * Address PR comments * Fixed linting errors * Address PR comments * Address PR comments * Address PR comments * Address PR comments * Fix linting errors * Refactor * Fix test failure * Refactor * Fix test failure * re-run test * Fix linting error and re-trigger pipeline * Re-record test and re-trigger CI * remove secret in yaml file * fix --------- Co-authored-by: Dan Vouaux <daniv@microsoft.com> Co-authored-by: xinyu pang <46143499+Greedygre@users.noreply.github.com> Co-authored-by: Greedygre <1042945277@qq.com>
…r creation and nodepool addition in AKS (Azure#7288) * Adding the cli command option for --pod-ip-allocation-mode * Added all the fields to read and populate the pod ip allocation mode from the az aks create and az aks nodepool commands with validations * Addressed all the code review comments by removing the Unassigned from the CLI, use the raw_param as the source of truth else fallback on agentpool config * Added a UT for the new podIPAllocationProperty * Added the new UT to be called on the required decorators * Added a live test case for podIPAllocationMode and creating a StaticBlock cluster * Added the necessary space * Simplified the logic to read from the agentpool profile if the value exists else deafault to the value provided by the user in the command line * Trying to fix the linter issues * Updated the code to adhere to the azdev styles * Fixed errors to adhere to the azdev styles * Attempting to not initialize any pod-ip-allocation-mode by default and then attach an agentpool with StaticBlock * Fixed param list * Adding the live only tag for the live test added * Fixed the missing '-' from the max-pods argument * Attempting to fix the resource ID for the node subnet * Attempting to fix the resource ID for the node subnet * Fixed the property name of the agentpoolprofile * Updated the expected value for podSubnetID * Added the logic to add the podIPAllocationMode to the agentpool network profile which was what was failing the CI * Removed the reference to agentpool network profile * Added a test case for managed_cluster properties generation * Added methods to update the pod ip allocation mode property of the agentpool to both the create and update methods * Fixing the variable name in the live test aks_name * Added the live test recording to the PR * Updated the PR based on the review comments to reorder the logic in the get method for the pod-ip-allocation-mode property and also removed the definition and call to set the property in the AgentPoolUpdateDecorator as the property option is only available in the aks create and aks nodepool add commands. * Updated the test cases based on the suggestions made in the PR review * Upated the History and setup.py files after rebasing to merge the new property in the next version * Fixed the assertion value * Fixed the azdev styles issue * Removed the liveonly tag * Excluding the test from the live test as it requires feature registration * Update src/aks-preview/azext_aks_preview/_help.py based on the suggested change Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> * Update src/aks-preview/azext_aks_preview/_help.py to use first-person voice. Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> --------- Co-authored-by: Ashish Nair <ashish.nair@microsoft.com> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
…rapp up` command (Azure#7198) * Fixed issue when registry creds are provided for ACRs in capp up * Lint error fixed * Addressed comments and added test recordings * Retriggering pipeline * Added missing tests * Rerun live tests * Re-recorded tests * Updated test recording * Updated failed test * Revert unmodified test * Fixed pylint errors * Updated HISTORY * Fixed indent * Updated test recordings --------- Co-authored-by: Greedygre <1042945277@qq.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=135128&view=results Last commit: Azure@c4eaa7d
… addon while creating AKS cluster. (Azure#7270) * Add parameter to set revision `--revision` for the Azure Service Mesh addon while creating AKS cluster. * fix style issues * added a unit test case * dynamically fetch asm supported revision for test cases. * fix azdev style error * update live test recording files. * changes as per review comments * Update src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py --------- Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=140179&view=results Last commit: Azure@30c636b
* Update vendored SDK versions and remove unused files * updated version notes * updated test recordings --------- Co-authored-by: Sean Hobbs <sehobbs@microsoft.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=140192&view=results Last commit: Azure@f3f8aeb
* feat: remove portal commands from apic-extension
…g and Versioning… (Azure#7371) * Change Login Migration Console App source to NuGet.org and Versioning support * Style check pylint changes * Add new release version and description * update the preview version number
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=140257&view=results Last commit: Azure@eafed37
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=140617&view=results Last commit: Azure@845801b
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=140828&view=results Last commit: Azure@0017504
…Azure#7271) * add new sdk * update version * update sdk * cli changes for PRPP * variable name fix, added test case * Add mode in copy job (cherry picked from commit a28144517ad4022098561e83d8607c93933dd36c) * Add complete job API (cherry picked from commit 3d721cb) (cherry picked from commit f4e6f01f99eb1299e8c536423f074e9832b71e16) * Add test * history.rst changes * Add history * Introduce disable_ttl parameter * Syntax error fixes * Update tests * Fix syntax error * Change test location to WestCentralUS where 0201 batch1 is completed, add remaining asserts, rerecordings * Update history file * Changed cluster deallocate force input to string * add missing changes from stable Azure/azure-cli#26226 * add stable changes https://github.com/Azure/azure-cli/pull/27175/files * https://github.com/Azure/azure-cli/pull/27322/files * add missing stable changes from https://github.com/Azure/azure-cli/pull/26392/files * Revert "https://github.com/Azure/azure-cli/pull/27322/files" This reverts commit f779e16. * add missing stable changes for minimal tls version from Azure/azure-cli#27322 * nit * Revert "nit" This reverts commit d4f4abe. * Revert "add missing stable changes for minimal tls version from Azure/azure-cli#27322" This reverts commit be4709e. * fix style checl * Address multi character short flag issue * Add missing parameters * Fix syntax issue * Remove short flag * fix test * poc for test changes * inital changes in custom.py * removing recordings * changes in params as well as test and recording for sql ntbr flow * fixing imports * fixing test * fixing recordings * config name change from --enable-per-region-per-partition-autoscale to --enable-prpp-autoscale * re-record tests * nit style * Revert "fixing recordings" This reverts commit ea5c847. * Revert "removing recordings" This reverts commit 583371c. * fixing incorrect merge * Added test * 6 out of 8 test failures * fixing remaining 2 tests * fixing style issues * Update HISTORY.rst to reflect changes ported from stable CLI * re-record cassandra tests * Update version to 1.0.0 due to breaking changes * azdev style fixes * azdev style fixes * azdev style fixes * azdev style fixes * azdev style fixes * azdev style fixes * Update HISTORY.rst version to 1.0.0 --------- Co-authored-by: Kushal Warke <kuwarke@microsoft.com> Co-authored-by: Nitesh Vijay <niteshvijay@microsoft.com> Co-authored-by: Nitesh Vijay <niteshvijay1995@gmail.com> Co-authored-by: Min Ho Kang <minhokang@microsoft.com> Co-authored-by: drewkaufmann <drewkaufmann@microsoft.com> Co-authored-by: Vivek Agarwal (from Dev Box) <agarwalvivek@microsoft.com> Co-authored-by: AgarwalVivek <vagarwal1@hawk.iit.edu>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=140834&view=results Last commit: Azure@7e7e029
…ation Service from upstream Git repositories. (Azure#7296)
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=141411&view=results Last commit: Azure@428d2a9
…#6986) * add connection string into app settings
* Update index.json New version added * Update index.json Preview flag removed * Update index.json sha updated * Update index.json json updated * Update index.json Static link added
…zure#7412) * Deprecated commands * Setup.py updated * Updates * Per comments * Style check
…ure#7387) * add a new cli extension for spot vm placement score * fix style checking failure * add mapping * change to az compute-diagnostic * syntax checking update * update readme
ninpan-ms
pushed a commit
that referenced
this pull request
Oct 17, 2024
* fix: --title --kind --custom-property parameters (#1) * feat: support yaml file in register command (Azure#3) * fix: workspace parameter should not be required (#2) * style: fix lint issues (Azure#6) * chore: update codeowner for apic-extension (Azure#5) * feat: revert changes to min cli version (Azure#4) * feat: resolve comments to CLI experience (Azure#10) * feat: mark "apic api register" command as preview (Azure#13) * feat: remove --terms-of-service parameter (Azure#12) * feat: remove --workspace-name parameter (Azure#11) * feat: support python 3.8 and 3.9 (Azure#14) * feat: fix command descriptions (Azure#17) * tests: add test cases for 'apic service' commands (Azure#16) * feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (Azure#19) * fix: CLI errors (Azure#20) * fix: import error when run CLI command * fix: no workspace name error when run import specification command * feat: mark some parameters as required (Azure#21) * feat: mark --assignments parameter required for metadata commands * doc: update sample commands * feat: mark --source-resource-ids parameter as required for import-from-apim command * doc: update description for import-from-apim command * feat: bump version to 1.0.0b5 and update changelog (Azure#18) * build: fix ci (Azure#22) * style: fix style warnings * test:fix test cases * fix: service update command failure (Azure#28) * doc: fix command samples (Azure#30) * doc: update changelog per feedback (Azure#29) * doc: remove extra spaces in register command help message (Azure#34) * doc: update api definition and metadata command samples (Azure#36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.