Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

chore: Bring acvm_js package into the workspace #459

Merged
merged 102 commits into from
Aug 8, 2023
Merged

chore: Bring acvm_js package into the workspace #459

merged 102 commits into from
Aug 8, 2023

Conversation

kobyhallx
Copy link
Contributor

Description

Problem*

Dev workflow is less efficient with acvm_js being in separate repository as per #458

Resolves #458

Summary*

Pulls in noir-lang/acvm-simulator into acvm_js directory.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

TomAFrench and others added 30 commits May 8, 2023 07:53
@TomAFrench
Initial commit
9959fcb
@TomAFrench
feat: add mvp abi encode/decode
8bdbcb6
@TomAFrench
feat: add circuit execution
7a66e88
@TomAFrench
chore: add comment on removal of vendored code
0d3b0ac
@TomAFrench
feat: replace opaque witness maps with js Maps
73801a9
@TomAFrench
chore: move js-witness conversion code into module
1c6bb83
@TomAFrench
feat: add support for oracle opcodes
f238d9b
@TomAFrench
chore: set up eslint
30103fb
@TomAFrench
chore: apply eslint fixes
5058791
@TomAFrench
chore: clippy fixes
f6c47e7
@TomAFrench
chore: clippy fix
1c7c5a7
@TomAFrench
chore: remove debugging code
51b511f
@TomAFrench
feat: return errors rather than panicking
cd7b8bf
@TomAFrench
fix(ci): update working directory for wasm build step
6fcdbee
@TomAFrench
feat: update to ACVM 0.11.0
248022a
@TomAFrench
Merge pull request noir-lang/acvm-simulator#2 from noir-lang/acvm-0.11.0
811cdd3 
feat: update to ACVM 0.11.0
@TomAFrench
chore(ci): Add initial testing for running simulator in the browser (n…
b6b98ee 
…oir-lang/acvm-simulator#3)
@TomAFrench
chore: remove unnecessary peer dependency
e97dd98
@TomAFrench
feat: use JS naming convention for generated functions (noir-lang/acv…
2571edb 
…m-simulator#6)
@TomAFrench
chore: add type aliases for tests (noir-lang/acvm-simulator#7)
3a4d7f7
@TomAFrench
feat: Enforce WitnessMap type in TS (noir-lang/acvm-simulator#9)
99131ac 
chore: implement `From` between JS and Rust witness maps
@TomAFrench
chore(ci): add eslint to CI (noir-lang/acvm-simulator#10)
fe4809e
@TomAFrench
chore: add smoketest for build-info (noir-lang/acvm-simulator#11)
c97bd45
@TomAFrench
chore: add release-please action (noir-lang/acvm-simulator#12)
b478a72
@TomAFrench
chore: add jsdoc for execute_circuit (noir-lang/acvm-simulator#13)
ab9f74b
@TomAFrench
chore: enforce type on oracle callback function (noir-lang/acvm-simul…
a03f76a 
…ator#15)
@TomAFrench
chore: update release secret name
cf18ba4
@TomAFrench
feat: update to ACVM 0.12.0 (noir-lang/acvm-simulator#1)
0f5d939 
chore: fill out optional fields of `Cargo.toml`
@Savio-Sou
chore(github): Remove Repo-tied Issue & PR Templates (noir-lang/acvm-…
ce91d73 
…simulator#31)

Co-authored-by: Globallager <72797635+Globallager@users.noreply.github.com>
@TomAFrench
chore: fix missing output in release-please CI (noir-lang/acvm-simula…
8910ce1 
…tor#32)
@kobyhallx kobyhallx force-pushed the combined_history-acvm_js branch 2 times, most recently from 783d410 to 451933f Compare August 2, 2023 10:17
@kobyhallx kobyhallx marked this pull request as ready for review August 2, 2023 11:38
TomAFrench
TomAFrench reviewed Aug 3, 2023
View reviewed changes
.github/workflows/release.yml Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
acvm_js/README.md Show resolved Hide resolved
release-please-config.json Show resolved Hide resolved
TomAFrench
TomAFrench reviewed Aug 3, 2023
View reviewed changes
acvm_js/.gitattributes Outdated Show resolved Hide resolved
@TomAFrench TomAFrench changed the title chore: Combined history acvm js chore: Bring acvm_js package into the workspace Aug 3, 2023
TomAFrench
TomAFrench approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running ./build.sh doesn't result in a build output in the right place for running tests on acvm_js however I think the fact we have CI working is fine. We can improve the build scripts later.

@kobyhallx kobyhallx disabled auto-merge August 8, 2023 09:22
@TomAFrench
Copy link
Member

@kevaundray can you force this through?

@kevaundray kevaundray added this pull request to the merge queue Aug 8, 2023
Merged via the queue into master with commit 85b9adc Aug 8, 2023
12 checks passed
@TomAFrench TomAFrench deleted the combined_history-acvm_js branch August 8, 2023 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: pull acvm_js into acvm
6 participants
@kobyhallx @TomAFrench @kevaundray @Savio-Sou @sirasistant @Maddiaa0