Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Methods for Execution details #18

Closed
Cliftonz opened this issue Oct 3, 2023 · 7 comments · Fixed by #28 or #26
Closed

Add Missing Methods for Execution details #18

Cliftonz opened this issue Oct 3, 2023 · 7 comments · Fixed by #28 or #26
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest 2023

Comments

@Cliftonz
Copy link

Cliftonz commented Oct 3, 2023

Some endpoints of the following section can't be hit from this SDK.

We would like to ensure that all endpoints can be hit. For this issue, we would like to build out the Execution details

Missing methods:

Get Execution Details - https://docs.novu.co/api-reference/execution-details/get-execution-details

@btkostner btkostner added enhancement New feature or request good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest 2023 labels Oct 3, 2023
@sccalabr
Copy link
Contributor

sccalabr commented Oct 6, 2023

id like to give this a try

@unicodeveloper
Copy link

Assigning this to you right now @sccalabr

@unicodeveloper
Copy link

Assigned ⭐

@sccalabr
Copy link
Contributor

sccalabr commented Oct 9, 2023

How do I hit the endpoint. Do I need to set up a server? The contributing section didnt mention how to run this

Also when I try to run tests I get this error

==> earmark_parser
Compiling 1 file (.yrl)
/usr/lib/erlang/lib/parsetools-2.3.2/include/yeccpre.hrl: no such file or directory
could not compile dependency :earmark_parser, "mix compile" failed. You can recompile this dependency with "mix deps.compile earmark_parser", update it with "mix deps.update earmark_parser" or clean it with "mix deps.clean earmark_parser"

any idea what this would happen? it is a clean checkout

@unicodeveloper
Copy link

You can hit the endpoint from the documentation to see how it works and the responses it returnes. I added the reference link. Grab your API key from https://web.novu.co/settings and use it to test it in the docs link. @sccalabr

CleanShot 2023-10-09 at 09 12 48

@sccalabr
Copy link
Contributor

sccalabr commented Oct 9, 2023

Thanks I'll give it a try later tonight. The elixir examples arent in the right hand side. You might want to create a task for that

@sccalabr
Copy link
Contributor

sccalabr commented Nov 1, 2023

@Cliftonz is there anything I need to fill out for hacktoberfest?

doomspork pushed a commit that referenced this issue Nov 9, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](v0.2.0...v0.3.0)
(2023-10-26)


### Features

* add environments module
([#24](#24))
([11487c6](11487c6))
* add Idempotency-Key header and exponential retry mechanism
([#31](#31))
([fd3754a](fd3754a))
* Add Missing Methods for Execution details
([#28](#28))
([aa28c83](aa28c83)),
closes [#18](#18)
* Add Missing Methods for Messages
([#29](#29))
([f718e2a](f718e2a)),
closes [#20](#20)
* set default maximum retry to zero
([#35](#35))
([c7bd600](c7bd600)),
closes [#33](#33)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest 2023
Projects
None yet
4 participants