Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Missing Methods for Messages #29

Merged
merged 2 commits into from
Oct 12, 2023
Merged

feat: Add Missing Methods for Messages #29

merged 2 commits into from
Oct 12, 2023

Conversation

sccalabr
Copy link
Contributor

Resolved #20

@doomspork
Copy link
Collaborator

@sccalabr would you mind running the CI checks locally going forward to make sure the work is ready to be reviewed before opening a PR and moving on to the next ticket?

@sccalabr sccalabr marked this pull request as draft October 11, 2023 01:19
@sccalabr
Copy link
Contributor Author

Ill convert it to a draft for now. I tried running things locally but I get this error

could not compile dependency :earmark_parser, "mix compile" failed. You can recompile this dependency with "mix deps.compile earmark_parser", update it with "mix deps.update earmark_parser" or clean it with "mix deps.clean earmark_parser"

I tried running all the different mix commands but it never went away :(

@sccalabr sccalabr marked this pull request as ready for review October 11, 2023 03:57
@sccalabr sccalabr marked this pull request as draft October 12, 2023 03:36
@sccalabr
Copy link
Contributor Author

@sccalabr would you mind running the CI checks locally going forward to make sure the work is ready to be reviewed before opening a PR and moving on to the next ticket?
@doomspork
Is there a way to run the workflows in my forked repo?

@sccalabr sccalabr marked this pull request as ready for review October 12, 2023 04:52
doomspork
doomspork approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@doomspork doomspork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sccalabr!

I would confirm the Elixir and Erlang versions you have and recompile your dependencies to see if that doesn't sort you out.

As for workflows I thought they'd run if you forked 🤔

@doomspork doomspork merged commit f718e2a into novuhq:main Oct 12, 2023
9 checks passed
@scopsy scopsy mentioned this pull request Oct 12, 2023
Merged
doomspork pushed a commit that referenced this pull request Nov 9, 2023
@scopsy
chore(main): release 0.3.0 (#26)
d637253 
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](v0.2.0...v0.3.0)
(2023-10-26)


### Features

* add environments module
([#24](#24))
([11487c6](11487c6))
* add Idempotency-Key header and exponential retry mechanism
([#31](#31))
([fd3754a](fd3754a))
* Add Missing Methods for Execution details
([#28](#28))
([aa28c83](aa28c83)),
closes [#18](#18)
* Add Missing Methods for Messages
([#29](#29))
([f718e2a](f718e2a)),
closes [#20](#20)
* set default maximum retry to zero
([#35](#35))
([c7bd600](c7bd600)),
closes [#33](#33)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doomspork doomspork doomspork approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Missing Methods for Messages
2 participants
@sccalabr @doomspork