Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set default maximum retry to zero #35

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

lovebes
Copy link
Contributor

@lovebes lovebes commented Oct 26, 2023

Set default retry config to be zero.
Add test to confirm that is indeed what happens.

Closes #33

@btkostner btkostner merged commit c7bd600 into novuhq:main Oct 26, 2023
10 checks passed
@scopsy scopsy mentioned this pull request Oct 20, 2023
doomspork pushed a commit that referenced this pull request Nov 9, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](v0.2.0...v0.3.0)
(2023-10-26)


### Features

* add environments module
([#24](#24))
([11487c6](11487c6))
* add Idempotency-Key header and exponential retry mechanism
([#31](#31))
([fd3754a](fd3754a))
* Add Missing Methods for Execution details
([#28](#28))
([aa28c83](aa28c83)),
closes [#18](#18)
* Add Missing Methods for Messages
([#29](#29))
([f718e2a](f718e2a)),
closes [#20](#20)
* set default maximum retry to zero
([#35](#35))
([c7bd600](c7bd600)),
closes [#33](#33)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum number of retries should default to zero
3 participants