feat: Add Missing Methods for Execution details #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sccalabr
changed the title
|
@sccalabr could you please address the failing CI checks? |
sccalabr
force-pushed
the
issue-18
branch
2 times, most recently
from
938408b
to
5da7d85
Compare
|
do work flows not run on drafts? |
|
@sccalabr Please attend to the failing tests. |
|
any problems with the pr? |
btkostner
requested changes
Oct 17, 2023
|
@sccalabr All the CI tests are failing. Please look into it |
|
The CI failures look to be coming from main branch. I'll open a PR soon to fix them Update: #32 |
btkostner
previously requested changes
Oct 19, 2023
There was a problem hiding this comment.
Code looks good. Just need to fix the format error in CI by running mix format and we should be good.
Removing unused variable
doomspork
approved these changes
Oct 20, 2023
doomspork
pushed a commit
that referenced
this pull request
Nov 9, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.0...v0.3.0) (2023-10-26) ### Features * add environments module ([#24](#24)) ([11487c6](11487c6)) * add Idempotency-Key header and exponential retry mechanism ([#31](#31)) ([fd3754a](fd3754a)) * Add Missing Methods for Execution details ([#28](#28)) ([aa28c83](aa28c83)), closes [#18](#18) * Add Missing Methods for Messages ([#29](#29)) ([f718e2a](f718e2a)), closes [#20](#20) * set default maximum retry to zero ([#35](#35)) ([c7bd600](c7bd600)), closes [#33](#33) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18