Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Idempotency-Key header and exponential retry mechanism #31

Merged
merged 5 commits into from
Oct 19, 2023
Merged

feat: add Idempotency-Key header and exponential retry mechanism #31

merged 5 commits into from
Oct 19, 2023

Conversation

Joao-Moura
Copy link
Contributor

  • Add new header Idempotency-Key using UUID v4
  • Expands exponential retry mechanism from the req library
  • Add new environments to configure retry
  • Update req lib (to have the retry step) and add elixir_uuid (to have UUID generation)

doomspork
doomspork reviewed Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@doomspork doomspork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Joao-Moura! One quick question on this but otherwise this is looking good. I'll pull this down and test before approving.

lib/novu/http.ex Outdated Show resolved Hide resolved
@Joao-Moura @doomspork
fix: update header to be case insensitive
3ec29c8 
Co-authored-by: Sean Callan <doomspork@users.noreply.github.com>
btkostner
btkostner approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@btkostner btkostner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Nice work @Joao-Moura! 🎊

@doomspork doomspork merged commit fd3754a into novuhq:main Oct 19, 2023
9 checks passed
@scopsy scopsy mentioned this pull request Oct 19, 2023
Merged
@unicodeveloper unicodeveloper added the hacktoberfest Improvements that qualify for Hacktoberfest 2023 label Oct 19, 2023
@doomspork doomspork mentioned this pull request Oct 19, 2023
Closed
5 tasks
doomspork pushed a commit that referenced this pull request Nov 9, 2023
@scopsy
chore(main): release 0.3.0 (#26)
d637253 
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](v0.2.0...v0.3.0)
(2023-10-26)


### Features

* add environments module
([#24](#24))
([11487c6](11487c6))
* add Idempotency-Key header and exponential retry mechanism
([#31](#31))
([fd3754a](fd3754a))
* Add Missing Methods for Execution details
([#28](#28))
([aa28c83](aa28c83)),
closes [#18](#18)
* Add Missing Methods for Messages
([#29](#29))
([f718e2a](f718e2a)),
closes [#20](#20)
* set default maximum retry to zero
([#35](#35))
([c7bd600](c7bd600)),
closes [#33](#33)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doomspork doomspork doomspork left review comments

@btkostner btkostner btkostner approved these changes

Assignees
No one assigned
Labels
hacktoberfest Improvements that qualify for Hacktoberfest 2023 hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joao-Moura @doomspork @btkostner @unicodeveloper