Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add baking pipeline capabilities, bugfixes for alpha values #363

Closed
wants to merge 15 commits into from
Closed

add baking pipeline capabilities, bugfixes for alpha values #363

wants to merge 15 commits into from

Conversation

ddengster
Copy link
Contributor

@ddengster ddengster commented Jun 24, 2021 •
edited
Loading

Bug fix/Fix applied

Alpha bugfixes

  1. Diffuse/Specular color value standardization: In our sdf exporters we use 3 floats for rgb, this standardizes it to 4 values rgba with the alpha being 1.0.
  2. .mtl file alpha fixes: Python would output alpha values as <param.ParamValue....>, a fix has been applied to cast it properly to floating point. Before this fix walls would appear black when imported in blender after being exported to dae.

New feature implementation

Implemented feature

  • Add capabilities to rmf_building_map_tools utilities
  1. ign_generate_dae generates .world files with the dae export plugin tag
  2. ign_baked_assets generates .world files that use the baked models (by default named L1)

Downstream PR: open-rmf/rmf_demos#58
**

ddengster and others added 9 commits June 4, 2021 10:57
@ddengster
add functionality to prepare a world for dae export
6104505 
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@ddengster
bugfixes for alpha values
d2d932f 
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@ddengster
style fixes
77e3734 
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@ddengster
Merge branch 'main' into dae_export
f14014f
@ddengster
remove doors from world generated by dae export
ac3081a 
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@ddengster
Merge branch 'main' into dae_export
f52e412
@ddengster
Merge branch 'main' into dae_export
cb87f54
@ddengster
Merge branch 'main' into dae_export
80f8542
@ddengster
add capability to generate ignition world using baked and nonbaked as…
5cee461 
…sets

Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@ddengster ddengster marked this pull request as ready for review June 24, 2021 08:32
@ddengster ddengster mentioned this pull request Jun 24, 2021
Closed
ddengster and others added 6 commits June 24, 2021 16:38
@ddengster
code style
b79ab17 
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@ddengster
Merge branch 'main' into dae_export
b5c901d
@ddengster
Merge branch 'main'
fd11333
@ddengster
modify traffic editor and build tools to cater for lightmap parameters
d260420 
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@ddengster
Merge branch 'main' into dae_export
9f4f90a
@ddengster
walls now exported properly
c639036 
streamlined baking pipeline into 1 command
renamed a bunch of stuff

Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@ddengster ddengster mentioned this pull request Sep 16, 2021
Open
5 tasks
@luca-della-vedova luca-della-vedova deleted the dae_export branch December 16, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddengster @luca-della-vedova