Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): Add LinterBuilder #5714

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

DonIsaac
Copy link
Contributor

This will replace OxlintOptions in an upstream PR. This also adds plugins to
Oxlintrc. This field gets respected by the builder, but not by
OxlintOptions.

Copy link
Contributor Author

DonIsaac commented Sep 11, 2024

Copy link

graphite-app bot commented Sep 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Sep 11, 2024

CodSpeed Performance Report

Merging #5714 will not alter performance

Comparing don/09-11-refactor_linter_add_linterbuilder_ (ba7b01f) with main (8ade793)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ branch from d778abb to e34d0b4 Compare September 12, 2024 13:08
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_add_linterbuilder_ branch from 6ff7d5e to f4c49b5 Compare September 12, 2024 13:08
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ branch from e34d0b4 to ae7618d Compare September 13, 2024 15:04
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_add_linterbuilder_ branch from f4c49b5 to dd8aac3 Compare September 13, 2024 15:04
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ branch from ae7618d to ffa122d Compare September 14, 2024 11:22
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_add_linterbuilder_ branch from dd8aac3 to e362064 Compare September 14, 2024 11:22
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ branch from ffa122d to 754f9e0 Compare September 16, 2024 17:37
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_add_linterbuilder_ branch from e362064 to 7993d57 Compare September 16, 2024 17:37
@DonIsaac DonIsaac added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 16, 2024
@Boshen Boshen changed the base branch from don/09-11-refactor_linter_move_override_rule_to_oxlintrules_ to graphite-base/5714 September 17, 2024 05:16
@Boshen Boshen force-pushed the don/09-11-refactor_linter_add_linterbuilder_ branch from 7993d57 to 739305d Compare September 17, 2024 05:21
@Boshen Boshen changed the base branch from graphite-base/5714 to main September 17, 2024 05:22
@Boshen Boshen force-pushed the don/09-11-refactor_linter_add_linterbuilder_ branch from 739305d to b544121 Compare September 17, 2024 05:22
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_add_linterbuilder_ branch 2 times, most recently from 8d9cfbb to 7654c6f Compare September 19, 2024 21:58
@DonIsaac DonIsaac marked this pull request as ready for review September 19, 2024 21:59
@DonIsaac DonIsaac requested a review from Boshen September 19, 2024 21:59
@DonIsaac DonIsaac added this to the Oxlint Beta Milestone milestone Sep 19, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 20, 2024
Copy link

graphite-app bot commented Sep 20, 2024

Merge activity

  • Sep 19, 9:23 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 19, 9:23 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 20, 7:57 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 20, 7:57 AM EDT: DonIsaac added this pull request to the Graphite merge queue.
  • Sep 20, 8:02 AM EDT: DonIsaac merged this pull request with the Graphite merge queue.

Boshen pushed a commit that referenced this pull request Sep 20, 2024
This will replace `OxlintOptions` in an upstream PR. This also adds `plugins` to
`Oxlintrc`. This field gets respected by the builder, but not by
`OxlintOptions`.
@Boshen Boshen force-pushed the don/09-11-refactor_linter_add_linterbuilder_ branch from 7654c6f to e0b565d Compare September 20, 2024 01:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 20, 2024
@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Sep 20, 2024
This will replace `OxlintOptions` in an upstream PR. This also adds `plugins` to
`Oxlintrc`. This field gets respected by the builder, but not by
`OxlintOptions`.
@DonIsaac DonIsaac force-pushed the don/09-11-refactor_linter_add_linterbuilder_ branch from e0b565d to ba7b01f Compare September 20, 2024 11:58
@graphite-app graphite-app bot merged commit ba7b01f into main Sep 20, 2024
26 checks passed
@graphite-app graphite-app bot deleted the don/09-11-refactor_linter_add_linterbuilder_ branch September 20, 2024 12:02
@oxc-bot oxc-bot mentioned this pull request Sep 23, 2024
Boshen added a commit that referenced this pull request Sep 23, 2024
## [0.9.7] - 2024-09-23

### Features

- d24985e linter: Add `oxc-security/api-keys` (#5906) (DonIsaac)
- f9b44c5 linter: Add unicode sets support to `no-useless-escape` rule
(#5974) (camchenry)
- 0f19848 linter: Implement `no-unexpected-multiline` rule (#5911)
(camchenry)
- 16fe383 linter: Implement `no-extend-native` rule (#5867) (Cam
McHenry)

### Bug Fixes

- eed9ac7 linter: Include actual span size in `no-regex-spaces`
diagnostic (#5957) (camchenry)
- 40c89c2 linter: Move `promise/avoid-new` to style category (#5961)
(DonIsaac)

### Performance

- 608d637 linter: Use `aho-corasick` instead of `regex` for string
matching in `jsx-a11y/img-redundant-alt` (#5892) (camchenry)
- 3148d4b linter: Check file path after checking node kind for
`nextjs/no-head-element` (#5868) (Cam McHenry)

### Refactor

- 0a5a4a9 linter: Use parsed patterns for `unicorn/no-hex-escape`
(#5985) (camchenry)
- 2cf2edd linter: Use parsed patterns in `no-empty-character-class` rule
(#5980) (camchenry)
- a9a8e2a linter: Use regex parser in `eslint/no-regex-spaces` (#5952)
(camchenry)
- 05f592b linter: Use parsed patterns in
`unicorn/prefer-string-starts-ends-with` (#5949) (camchenry)
- 3273b64 linter: Use parsed patterns for
`unicorn/prefer-string-replace-all` rule (#5943) (camchenry)
- ba7b01f linter: Add `LinterBuilder` (#5714) (DonIsaac)
- db4f16a semantic: Call `with_trivias` before `build_with_jsdoc`
(#5875) (Boshen)
- 3d13c6d semantic: Impl `IntoIterator` for `&AstNodes` (#5873)
(DonIsaac)

### Testing

- b681c9a linter: Import test cases for `no-empty-character-class`
(#5981) (camchenry)
- 767602b linter: Add regression test for #5227 (#5975) (camchenry)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants