Fixed docstrings as referenced in issue no: #24071 #26520
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26520 +/- ##
==========================================
- Coverage 91.75% 91.74% -0.01%
==========================================
Files 174 174
Lines 50665 50665
==========================================
- Hits 46489 46485 -4
- Misses 4176 4180 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26520 +/- ##
==========================================
- Coverage 91.75% 91.74% -0.01%
==========================================
Files 174 174
Lines 50665 50665
==========================================
- Hits 46489 46485 -4
- Misses 4176 4180 +4
Continue to review full report at Codecov.
|
Follow-up to gh-26466
|
Yep. Lot of file changes. Thanks so much for the link. I went through the options, but none of them seem to be helping me sort out my branch. It is be because I merged the master with this branch. Man, my branch is a real mess now. Any idea how I can rebase this branch to my first commit so that I can remove the other unrelated commits from here? |
|
if the instructions in the link I sent don't work, you'll probably want to start a new branch from an updated master, and manually apply the relevant commits from this branch there. |
|
Yep. Just doing that. Sorry, but major noob question again. Is it possible
for me to update this same PR with a new branch with just the related
changes? Or would I have to raise a new PR with the changes and we could
close this one?
Warm Regards,
Mathew George
Mob: +91-9820502747
…On Sun, May 26, 2019 at 3:19 PM Marc Garcia ***@***.***> wrote:
if the instructions in the link I sent don't work, you'll probably want to
start a new branch from an updated master, and manually apply the relevant
commits from this branch there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26520?email_source=notifications&email_token=AF2JNPA7PGQ55XFARSPQXT3PXJMI5A5CNFSM4HPUUFMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWICAUI#issuecomment-495984721>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF2JNPDL2HI3PETBTKWGDLTPXJMI5ANCNFSM4HPUUFMA>
.
|
|
You surely can, but if you're unsure of those things, better do the simplest thing. pandas is not the best project for experimenting, this is creating noise for too many people. |
|
Closing this PR. I'm terribly sorry about the noise. Did not mean to waste anybody's time. Thank you so much for your patience with me. |
|
No worries, this problem with the branch happens very often (that's why I wrote the post on how to fix it). My point is only to better not try fancy things pushing here, as this notifies many people. Feel free to open a new PR with the changes, and let's continue there. Thanks! |
git diff upstream/master -u -- "*.py" | flake8 --difftests :
./scripts/validate_docstrings.py --prefix=pandas.core --errors=GL01,GL02