Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the maximum available CPU/Memory on TiFlash Grafana panel #3852

Closed
wants to merge 5,289 commits into from
Closed

Show the maximum available CPU/Memory on TiFlash Grafana panel #3852

wants to merge 5,289 commits into from

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Jan 12, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #3821

Problem Summary:

What is changed and how it works?

todo : need test with cgroup

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 12, 2022
@jiaqizho
Copy link
Contributor Author

/rebuild

@jiaqizho
Copy link
Contributor Author

grafana updated :
841642063374_ pic

@jiaqizho jiaqizho changed the title [WIP] Show the maximum available CPU/Memory on TiFlash Grafana panel Show the maximum available CPU/Memory on TiFlash Grafana panel Jan 13, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2022
JaySon-Huang and others added 22 commits March 15, 2022 21:13
@JaySon-Huang
Use CRC64 as checksum algo for LogFile (#4261)
0ec758c 
ref #3594
@solotzg
Clean deprecated directories and internal links (#4278)
14185f7 
ref #4141
@windtalker
fix bug that ExchangeReceiver is not cancelled if exception happens i…
0e40b9e 
…n union/agg block input stream (#4285)

ref #4229
@gengliqi
Support dayofweek and dayofyear pushdown to tiflash (#4222)
0daf533 
close #4150
@bestwoody @fuzhe1989
refine tiflash shutdown logic (#4291)
146a99a 
* 1.add metrics of calldata&mpptunnel 2.refine shutdown logic

Signed-off-by: bestwoody <bestwoody@163.com>

* update

* Apply suggestions from code review

Co-authored-by: Fu Zhe <fuzhe1989@gmail.com>

* Update dbms/src/Flash/EstablishCall.cpp

Co-authored-by: Fu Zhe <fuzhe1989@gmail.com>

* add harm limit to wait

Signed-off-by: bestwoody <bestwoody@163.com>

* fix

Signed-off-by: bestwoody <bestwoody@163.com>

Co-authored-by: Fu Zhe <fuzhe1989@gmail.com>
@jiaqizho
WALStore support multi path (#4085)
6141520 
ref #3594
@solotzg
Limit build release parallelism (#4301)
b9379c4 
ref #4141
@SeaRise
add HashJoinProbeBlockInputStream (#4246)
502dd4a 
close #4248
@yibin87
Add CI license check flow config file (#4294)
6ffc427 
close #4292
@windtalker
make mpp_fail test stable (#4300)
f030da8 
close #4299
@JinheLin
README.md: Rename tics to tiflash. (#4296)
d385f0a 
ref #4019
@SchrodingerZhu
fix potential asan error for string tests (#4279)
946b72e 
close #4280
@fuzhe1989
MPP: ExchangeReceiver supports async gRPC (#3715)
de7bc99 
close #4298
@yibin87
Replace old CK license with standard Apache 2.0 License (#4306)
0948c8a 
close #4305
@lidezhu
Fix crash when read ColumnFileTiny in MemTableSet (#4297)
59d9ed0 
close #4204
@guo-shaoge
cleanup benchmark (#4233)
8723b25 
close #4232
@fzhedu
Min tso metrics (#4260)
c0c63f3 
close #4256
@windtalker
fix bug of handling zero date in dayofweek and dayofyear (#4314)
a53783d 
close #4313
@windtalker
use the right way to wait tiflash replica ready in least_greatest.test (
19c3e48 
#4317)

close #4316
@lidezhu
print table_id for table which is applying snapshot (#4310)
4e52ac8 
close #4311
@fzhedu
Scheduler: release threads by tasks (#4307)
aacd920 
close #4308
@fuzhe1989
Fix bug that TiFlash will crash when enable both async_grpc_client an…
fe5a3d7 
…d local_tunnel (#4322)

close #4321
fzhedu and others added 15 commits May 20, 2022 11:22
@fzhedu
expression: check Overflow int128 (#4762)
70a2770 
close #4512
@jiaqizho
Add a fail point named force_change_all_blobs_to_read_only (#4920)
759d022 
ref #3594
@jiaqizho
Fix StorageDeltaMerge constructor not match in gtest_manual_compact (#…
120d0a8 
…4950)

close #4949
@zanmato1984
Add note about how to handle build oom or hang (#4951)
ebf12fa 
close #4953
@lidezhu @JaySon-Huang
flush cache before segment merge (#4955)
b9289cd 
* flush cache before segment merge

* keep flush until success

* check whether segment is valid if flush failed

* Update dbms/src/Storages/DeltaMerge/tests/gtest_dm_segment.cpp

Co-authored-by: JaySon <tshent@qq.com>

* add more fix

* check flush result in segment::write

Co-authored-by: JaySon <tshent@qq.com>
@jiaqizho
Add a global max_id to fix reuse page_id problem (#4948)
4044129 
close #4939
@fzhedu
Schedule: track the waiting tasks with task ID, and deleted the sched…
26b11f9 
…uled task with exceeded state from the waiting tasks queue (#4958)

close #4954
@solotzg
Enable LTO in release build process (#4924)
f9eb43b 
ref #4909
@hehechen
Revert the retry applyRecord when loadEdit (#4938)
2948e03 
close #4937
@solotzg
Remove useless template instantiations (#4978)
caaff2a 
ref #4909
@SeaRise
fix clang tidy err for ExpressionAnalyzer, Join, StorageJoin, `…
1a79d29 
…DAGQueryBlockInterpreter` (#4961)

ref #4605
@SeaRise
refine handleJoin (#4722)
5e55fa8 
ref #4118
@jiaqizho
Change BlobFileId to uint64. (#4984)
2f845ef 
ref #3594
@ywqzzy
*: Rename the function with “withCollation” postfix (#3790)
11224ce 
close #4985
@JaySon-Huang
PageStorage: Fix the WAL snapshot dumped into file may contains inval…
5e781b2 
…id "being_ref_count" (#4987)

close #4957, close #4986
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2022
@ti-chi-bot
Copy link
Member

@jiaqizho: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 26, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

Assignees

@Lloyd-Pottiger Lloyd-Pottiger

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the maximum available CPU/Memory on TiFlash Grafana panel