Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Branch: merge master to planner_refactory branch #5034

Merged
merged 24 commits into from
Jun 8, 2022
Merged

Feature Branch: merge master to planner_refactory branch #5034

merged 24 commits into from
Jun 8, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented May 31, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4739

Problem Summary:

What is changed and how it works?

first pr of feature branch planner_refactory

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

windtalker and others added 10 commits May 26, 2022 21:12
@windtalker
Refine function test framework (#4861)
973de13 
close #4830
@yibin87 @ti-chi-bot
Add mutex to protect exchange receiver's async client (#5008)
f10b6d2 
* Add to_seconds support for tiflash

Signed-off-by: yibin <huyibin@pingcap.com>

* Fix format issue

Signed-off-by: yibin <huyibin@pingcap.com>

* Add mutex lock to protect async reciever async reader

Signed-off-by: yibin <huyibin@pingcap.com>

* Fix a rebase issue

Signed-off-by: yibin <huyibin@pingcap.com>

* Change raw pointer to unique ptr

Signed-off-by: yibin <huyibin@pingcap.com>

* Fix format issue

Signed-off-by: yibin <huyibin@pingcap.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@jiaqizho
Optimize blobstore gc when current stat total size is 0 (#5015)
d84f273 
close #5016
@Lloyd-Pottiger
Fix an invalid default value cause bootstrap failed (#4916)
ca3e1c6 
close #3157
@JaySon-Huang
PageStorage: Report the file usage of BlobStore (#4999)
d1ecebd 
close #4922
@hehechen
Fix unstable ut in the master branch (#5024)
7dff463 
close #5023
@windtalker
refine get type from decimal literal (#5014)
c8624a0 
close #5007
@hzh0425
Refactor: add new module schema (#4932)
516fa15 
ref #4646
@breezewish
docs: Add rfc for compact table via sql (#4929)
335b124 
ref #4897
@JaySon-Huang
Fix broken unit test for `--gtest_filter='*StorageDeltaMergeTest*:*Re…
580821a 
…gionKVStoreTest*'` (#4903)

close #4904
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 31, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 31, 2022
@SeaRise SeaRise changed the title Feature Branch: merge master Feature Branch: merge master to planner_refactory branch May 31, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented May 31, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
hongyunyan and others added 12 commits May 31, 2022 16:40
@hongyunyan
Remove useless code (#5004)
6afdd74 
close #4998
@hehechen
Add mix mode UT (#5012)
a0ed1a6 
close #5028
@lidezhu
support mix_mode in dt_workload (#5011)
800715c 
ref #3594
@windtalker
enable new function test framework by default (#5029)
380f6cd 
ref #4830
@hehechen
Tiflash pagectl support encrypted data (#5003)
187a591 
close #4962
@Lloyd-Pottiger
update tiflash proxy (#5043)
226dff6 
ref #4879
@lidezhu
Fix potential data inconsistency under heavy ddl operation (#5044)
2ce9529 
* fix decoding error under heavy ddl operation

* small fix
@ywqzzy
*: fix invalid fmt format string in CreatingSetsBlockInputStream.cpp (#…
20d2198 
…5053)

ref #5052
@lidezhu
increase bg gc check interval (#5056)
677ad75 
close #5057
@JaySon-Huang
PageStorage: Fix pages are not deleted under some cases (#5069)
b49a787 
close #5054
@lidezhu
Fix unstable drop table unit test (#5059)
a66c082 
close #5060
@JaySon-Huang
Fix broken ut SegmentDeletionRelevantPlaceTest (#4607)
e3a4412 
close #4606
@SeaRise
Copy link
Contributor Author

SeaRise commented Jun 7, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jun 7, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@SeaRise: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jun 7, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jun 7, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@SeaRise SeaRise requested review from ywqzzy and windtalker June 7, 2022 10:31
@SeaRise
Copy link
Contributor Author

SeaRise commented Jun 7, 2022

wait for #5041

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 7, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18281      9730             46.78%    205105  97550        52.44%

full coverage report (for internal network access only)

ywqzzy
ywqzzy approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2022
@SeaRise SeaRise mentioned this pull request Jun 8, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 8, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jun 8, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fdab3f5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 8, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18311      9641             47.35%    205470  96570        53.00%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 44c4400 into planner_refactory Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@windtalker windtalker Awaiting requested review from windtalker

@LittleFall LittleFall Awaiting requested review from LittleFall

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.