Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Branch: merge master to planner_refactory #5493

Merged
merged 31 commits into from
Aug 3, 2022
Merged

Feature Branch: merge master to planner_refactory #5493

merged 31 commits into from
Aug 3, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jul 28, 2022

What problem does this PR solve?

Issue Number: close #4739

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

JaySon-Huang and others added 18 commits July 21, 2022 21:09
@JaySon-Huang
build: Fix build under intel mac machine (pingcap#5447)
c2e9f96 
ref pingcap#5368
@CalvinNeo
fix TiFlash wait index timeout due to not replicated filtered commands (
f11c6c4 
pingcap#5446)

close pingcap#5445
@YangKeao
feat: implement hexInt/hexStr function push down (pingcap#5280)
6a8c26c 
close pingcap#5107
@solotzg
*: try not to use lld as default linker in macos (pingcap#5451)
3ad743b 
ref pingcap#5368
@Lloyd-Pottiger
fix: incorrect uptime in grafana panel (pingcap#5358)
c823138 
close pingcap#5355
@JinheLin
fix sched_setaffinity failed. (pingcap#5459)
e289119 
close pingcap#5457
@An-DJ
feat: support 'bin' function push down (pingcap#5246)
da32955 
close pingcap#5103
@xzhangxian1008
Support colllation for planner refactory test framework (pingcap#5449)
679eda6 
close pingcap#5432
@SeaRise
refine InterpreterDAG (pingcap#5466)
a476307 
ref pingcap#4739
@YangKeao
fix hexInt sprintf format pattern (pingcap#5460)
c4ad3f1 
close pingcap#5462
@JinheLin
Fix typo of Metrics (pingcap#5472)
53e2c42 
close pingcap#5473
@ywqzzy
refine FlashService (pingcap#5471)
28d3991 
ref pingcap#4609
@fuzhe1989
*: improve RUNTIME_CHECK and RUNTIME_ASSERT (pingcap#5434)
e5f0eb4 
close pingcap#5444
@SeaRise
refine Window Executor Test (pingcap#5464)
ee2f753 
ref pingcap#4609, close pingcap#5465
@JinheLin @flowbehappy
Add metrics of Read Thread and Cache (pingcap#5476)
72f7481 
Co-authored-by: Flowyi <flowbehappy@gmail.com>
@bestwoody
bugfix for core of GRPCCompQueue when tiflash shutdown (pingcap#5483)
245e2fb 
close pingcap#5480
@breezewish
test: Add tests case when deltaMergeBySplit + { flushCache | split } …
ad5201c 
…occurs simultaneously (pingcap#5454)

ref pingcap#5409
@JinheLin
Design doc: DeltaTree Read Thread Pool and Data Sharing (pingcap#5478)
bcb029e 
ref pingcap#5488
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 28, 2022
@SeaRise SeaRise changed the base branch from master to planner_refactory July 28, 2022 09:59
@SeaRise SeaRise changed the title Feature Branch: merge master to planner_refactory [DNM] Feature Branch: merge master to planner_refactory Jul 28, 2022
@SeaRise SeaRise changed the title [DNM] Feature Branch: merge master to planner_refactory Feature Branch: merge master to planner_refactory Jul 28, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2022
@SeaRise SeaRise reopened this Aug 3, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 3, 2022

/check-license

@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 3, 2022

/run-check-license

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 3, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
19223      9265             51.80%    218265  94360        56.77%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@SeaRise SeaRise mentioned this pull request Aug 3, 2022
Merged
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 3, 2022

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 120214f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 3, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Aug 3, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
19223      9263             51.81%    218265  94322        56.79%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 67a084c into pingcap:planner_refactory Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@LittleFall LittleFall LittleFall approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. tide/merge-method-merge Denotes a PR that should be merge by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interpreter planner refactor