Add Atomx support #1056
Add Atomx support #1056
Conversation
|
Hey @erikdubbelboer , just a heads up that you may want to also submit a PR to have your adaptor documented on prebid.org :-) https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders |
|
@aneuway2 I already had this ready but was waiting for this to be merged. Created the pull request now anyways: prebid/prebid.github.io#201 |
src/adapters/atomx.js
Outdated
| utils.logError(_error); | ||
| } | ||
| if (bid.cpm > 0) { | ||
| bidObject = bidfactory.createBid(1); |
There was a problem hiding this comment.
pass bidrequest object as second argument to match bid request/response pair
src/adapters/atomx.js
Outdated
| bidObject.width = bid.width; | ||
| bidObject.height = bid.height; | ||
| } else { | ||
| bidObject = bidfactory.createBid(2); |
There was a problem hiding this comment.
pass bidrequest object as second argument to match bid request/response pair
erikdubbelboer
force-pushed
the
atomx
branch
2 times, most recently
from
4d545be
to
499aeb2
Compare
|
@jaiminpanchal27 sorry, I should have paid better attention. The bugs have been fixed. |
|
@erikdubbelboer I have created a test page and the creatives loaded on the page always navigates the parent page. |
|
@jaiminpanchal27 my mistake, I should have given you a proper ID. Try: {
bidder: 'atomx',
params: { id: 7395 }
} |
|
LGTM. |
|
This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
|
@mkendall07 Is there any reason why Atomx isn't in the "New adapter" list here but instead separately? |
|
@erikdubbelboer |
…built * 'master' of https://github.com/prebid/Prebid.js: (38 commits) Add optional domain parameter to AdButler adapter (prebid#1078) Send transactionID to Criteo Services (prebid#1113) Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106) Remove placement size selection and filtering (prebid#1107) revert `srcdoc` change (prebid#1130) Add new Adapter- Beachfront Media (prebid#1062) Fixes SpringServe adapter (prebid#1101) Update Widespace request param (prebid#1098) - New Adapter: Innity (prebid#1074) Update Roxot prebid analytic adapter (prebid#1034) Yarn Package Manager (prebid#1109) allow writing into current document if prebid is loaded inside an iframe (prebid#1066) Adapter bug fix (prebid#1096) fix typo added pr review process and governance model (prebid#1103) added support for sampling in ga and base adapter, fixed up some tests (prebid#1011) Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) ...
…19.0 to aolgithub-master * commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits) Disable unit tests that fails on PhantomJs. Fixed unit tests for adapter loader. Changed way of including analytic adapters. Added adapters in aolPartnersIds.json. Added changelog entry. Replace removed utils.extend functionality by object.assign. Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) Updated rubicon video bid endpoint in source and test files (prebid#1097) Pass through params to server (prebid#1084) Reset the list of slots to be requested between each action for pubmatic (prebid#1079) Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021) update PR template to include link to dev docs page (prebid#1075) Prebid 0.21.0 Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054) Video header bidding support to RhythmOne bidder adapter (prebid#1052) Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045) Fix adapter getSize (prebid#1064) ...
Type of change
Description of change
Add Atomx bidder adapter.