Adapter bug fix #1096
Merged
Adapter bug fix #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce they are hardcoded.
Also making sure we encode/decode site and page parameters.
# Conflicts: # package.json # src/adaptermanager.js
Fix unit tests after refactoring
Merge remote-tracking branch 'upstream/master' # Conflicts: # package.json
# Conflicts: # .gitignore # package.json # src/adapters/wideorbit.js # test/spec/adapters/wideorbit_spec.js
# Conflicts: # integrationExamples/gpt/pbjs_example_gpt.html # src/adapters/wideorbit.js
mkendall07
reviewed
Mar 30, 2017
| }; | ||
|
|
||
| $$PREBID_GLOBAL$$.handleWideOrbitCallback(response); | ||
|
|
There was a problem hiding this comment.
shouldn't you assert that addBidResponse wasn't invoked here?
There was a problem hiding this comment.
It will actually call addBidResponse. It will however not throw an exception as it did before. I agree the test isn't very good, but it did catch my particular issue.
|
LGTM |
outoftime
added a commit
to Genius/Prebid.js
that referenced
this pull request
Apr 19, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (38 commits) Add optional domain parameter to AdButler adapter (prebid#1078) Send transactionID to Criteo Services (prebid#1113) Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106) Remove placement size selection and filtering (prebid#1107) revert `srcdoc` change (prebid#1130) Add new Adapter- Beachfront Media (prebid#1062) Fixes SpringServe adapter (prebid#1101) Update Widespace request param (prebid#1098) - New Adapter: Innity (prebid#1074) Update Roxot prebid analytic adapter (prebid#1034) Yarn Package Manager (prebid#1109) allow writing into current document if prebid is loaded inside an iframe (prebid#1066) Adapter bug fix (prebid#1096) fix typo added pr review process and governance model (prebid#1103) added support for sampling in ga and base adapter, fixed up some tests (prebid#1011) Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) ...
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Added WideOrbit adapter * Fix User Matching code * Renamed adapter + some minor JS issues * Added flag for notifying front action is header bidding. Use returned bid. * Duplicated properties fixed. * Correcting adaptermanager after wrong merge. Now all tests passes correctly. * Seting fl and jscb directly in the pageImpression-part of the url, since they are hardcoded. * Fixed above the fold parameter * No need to modify original value. * Normalizing file regarding single or double quotes. Also, properly indenting. * Removed uneeded properties: referrer (twice) and tagId. * Slightly better readiblity for variable declarations (and definition in some cases). * Refactoring regarding function naming and the way we set rank parameter. Also making sure we encode/decode site and page parameters. * Ignoring TypeScript's typing definitions. * Added initial WideOrbit Adapter tests covering url-creation part. * Completed wide orbit adapter tests with the one regarding callback response. * Slightly better test names. * Fix support for already prepared tracking pixels * Modified indenting according to coding standard * Code review fixes * Marked required parameters * Remove unused library from package.json Fix unit tests after refactoring * Added support for referrer * Added support for referrer * Updated line endings to UNIX style * Fixed formatting issue * Fix user matching identification for JavaScript type * Duplicated WideOrbit spec after merge * Made adapter more robust for server misconfiguration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We had a an issue server side that output the wrong identifier string to our adapter which caused the adapter to fail with an exception.
In order to avoid this in the future, we made the adapter more robust for this kind of errors.