- New Adapter: Innity #1074
Merged
- New Adapter: Innity #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 27, 2016 11:39
Innity Adapter
jaiminpanchal27
requested changes
Apr 5, 2017
src/adapters/innity.js
Outdated
| var bidObject = {}, callbackID, libURL = window.location.protocol + "//cdn.innity.net/frame_util.js"; | ||
| callbackID = response.callback_uid; | ||
| if (response.cpm > 0) { | ||
| bidObject = bidfactory.createBid(CONSTANTS.STATUS.GOOD); |
There was a problem hiding this comment.
use bidRequest object as second argument to match bid request/response pair
src/adapters/innity.js
Outdated
| bidObject.width = response.width; | ||
| bidObject.height = response.height; | ||
| } else { | ||
| bidObject = bidfactory.createBid(CONSTANTS.STATUS.NO_BID); |
There was a problem hiding this comment.
use bidRequest object as second argument to match bid request/response pair
test/spec/adapters/innity_spec.js
Outdated
| var utils = require('src/utils'); | ||
| var CONSTANTS = require('src/constants.json'); | ||
|
|
||
| window.pbjs = window.pbjs || {}; |
There was a problem hiding this comment.
use
|
|
||
| it('bid request for single placement', function () { | ||
|
|
||
| var params = { |
There was a problem hiding this comment.
Format this file properly.
adapters.json
Outdated
| @@ -18,6 +18,7 @@ | |||
| "gumgum", | |||
| "hiromedia", | |||
| "indexExchange", | |||
| "innity", | |||
test/spec/adapters/innity_spec.js
Outdated
| var adapter = require('src/adapters/innity'); | ||
| var adLoader = require('src/adloader'); | ||
| var bidmanager = require('src/bidmanager'); | ||
| var utils = require('src/utils'); |
There was a problem hiding this comment.
You are not using utils, CONSTANTS anywhere. Remove them if not required
test/spec/adapters/innity_spec.js
Outdated
| if (typeof(pbjs._bidsRequested) === "undefined") { | ||
| pbjs._bidsRequested = []; | ||
| } | ||
| if (typeof(pbjs._adsReceived) === "undefined") { |
There was a problem hiding this comment.
Why do you need _adsReceived here ? How are you using this ?
added 3 commits
April 6, 2017 16:37
- Align innity in adapters.json - Format innity_spec.js - Add bidRequest into innity.js
|
@jaiminpanchal27 We have made the necessary changes, thanks. |
jaiminpanchal27
approved these changes
Apr 10, 2017
|
LGTM. |
|
This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
outoftime
added a commit
to Genius/Prebid.js
that referenced
this pull request
Apr 19, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (38 commits) Add optional domain parameter to AdButler adapter (prebid#1078) Send transactionID to Criteo Services (prebid#1113) Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106) Remove placement size selection and filtering (prebid#1107) revert `srcdoc` change (prebid#1130) Add new Adapter- Beachfront Media (prebid#1062) Fixes SpringServe adapter (prebid#1101) Update Widespace request param (prebid#1098) - New Adapter: Innity (prebid#1074) Update Roxot prebid analytic adapter (prebid#1034) Yarn Package Manager (prebid#1109) allow writing into current document if prebid is loaded inside an iframe (prebid#1066) Adapter bug fix (prebid#1096) fix typo added pr review process and governance model (prebid#1103) added support for sampling in ga and base adapter, fixed up some tests (prebid#1011) Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) ...
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Oct 27 Oct 27 * Added Innity Innity Adapter * Innity GPT Test Page * Restore Master pbjs_example_gpt.html * Changes based on jaiminpanchal27 feedback - Align innity in adapters.json - Format innity_spec.js - Add bidRequest into innity.js * Fixed formatting and remove unnecessary code (prebid#1074)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Hi, new Innity Prebid.js adapter
Other information
Thanks.