Add Facebook Audience Network adapter #1068

lovell · 2017-03-22T22:43:18Z

Type of change

Description of change

Hello, I'm sure some contributors to this very useful header bidding product will be aware of the recent news that Facebook Audience Network now supports header bidding.
https://adexchanger.com/publishers/facebook-launches-header-bidding-turns-partners-tech/

As well as the adapter itself, this PR includes an integration example of its possible use.

(The branch coverage of the provided unit tests is 100% but due to the coverage reporter's use of ES5 this is currently displayed as only 59%. I hope this is OK.)

Feedback is very much welcome.

official adapter submission

mkendall07 · 2017-03-24T21:24:44Z

@lovell
I think we have to wait for an official Fb submission.

lovell · 2017-03-24T21:42:24Z

Hi Matt, the work for this PR was commissioned and paid for by Facebook, sorry I didn't make that clear in the first instance. I'll ask one of their full-time employees to verify this.

matthewlane

Hi @lovell, the bidder params in the provided integration example aren't returning valid responses, do you have test params we could use for validating bids?

Also a few initial notes below for your review. Thanks a lot for this adapter PR!

matthewlane · 2017-03-28T19:53:47Z

src/adapters/audienceNetwork.js

+      // Handle response
+      const data = parseJson(res);
+      if (data.errors && data.errors.length) {
+        addBidResponse(null, createFailureBidResponse());


addBidResponse should take an ad unit code as the first param even for nobid responses

matthewlane · 2017-03-28T19:54:39Z

src/adapters/audienceNetwork.js

+    }, null, { withCredentials: true });
+  } else {
+    // No valid bids
+    addBidResponse(null, createFailureBidResponse());


please also pass in the ad unit code as first param here

lovell · 2017-03-29T16:58:41Z

Hello @matthewlane, you should be able to create a new "App" for testing purposes at https://developers.facebook.com/apps then add the "Audience Network" product to it. This will then allow you to create a "Placement" and therefore provide you with the placementId. You'll need to ensure the User-Agent request header represents a mobile device to get a non-zero bid.

We should probably add these steps to the example :)

matthewlane · 2017-03-29T23:56:36Z

Thanks for the instructions @lovell. I've gone through and created a placementId, but am getting a response of Application not authorised for header bidding, even with a mobile User-Agent. Looking through the dev site and docs to research this but any idea how to go about authorizing a test app for header bidding with Audience Network?

wheresbarney · 2017-03-30T09:21:35Z

What's your app ID, @matthewlane? It needs to be approved for Audience Network header bidding - I can do that.

matthewlane · 2017-03-30T16:36:01Z

Thanks @wheresbarney, the app ID is 1780499291962017

mkendall07 · 2017-03-31T12:21:34Z

@lovell
When do you think you will have code review updates complete?

lovell · 2017-03-31T15:09:45Z

@mkendall07 I expect to update this later today, thanks for the nudge.

wheresbarney · 2017-03-31T18:16:23Z

@mkendall07 - I've approved your app ID. You should be able to get bids as long as you're signed in to FB on the same session, and you've got a mobile user agent.

lovell · 2017-03-31T20:03:14Z

@mkendall07 The code is now updated to call addBidResponse with all valid ad unit codes when no bids are received, plus the "quick start" steps I provided above are now in the integration example.

matthewlane

Was able to verify bid responses. Thanks for the update, looks good to me

mkendall07 · 2017-03-31T20:25:31Z

src/adapters/audienceNetwork.js

+ * and therefore indicate testmode should be used?
+ * @returns {String} "true" or "false"
+ */
+const isTestmode = () => Boolean(


What's the test mode for?

This detects the addition of ?anhb_testmode in a given page's URL so only test bids are returned. Those test bids won't be honoured beyond the initial response. I guess/hope any official FB API docs will include mention of this but happy to add this to the "quick start" in the example too if required.

Mostly just curious. Thanks.

mkendall07 · 2017-03-31T20:34:11Z

LGTM

wheresbarney · 2017-04-03T15:20:38Z

Thanks @matthewlane, @lovell. Do we need to do anything for the AN adaptor to end up in the configure-and-compile downloader at http://prebid.org/download.html?

mkendall07 · 2017-04-03T16:04:24Z

This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

mkendall07 · 2017-04-03T16:04:49Z

@wheresbarney see above message. That's all that is required and we will update the rest.

…built * 'master' of https://github.com/prebid/Prebid.js: (38 commits) Add optional domain parameter to AdButler adapter (prebid#1078) Send transactionID to Criteo Services (prebid#1113) Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106) Remove placement size selection and filtering (prebid#1107) revert `srcdoc` change (prebid#1130) Add new Adapter- Beachfront Media (prebid#1062) Fixes SpringServe adapter (prebid#1101) Update Widespace request param (prebid#1098) - New Adapter: Innity (prebid#1074) Update Roxot prebid analytic adapter (prebid#1034) Yarn Package Manager (prebid#1109) allow writing into current document if prebid is loaded inside an iframe (prebid#1066) Adapter bug fix (prebid#1096) fix typo added pr review process and governance model (prebid#1103) added support for sampling in ga and base adapter, fixed up some tests (prebid#1011) Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) ...

…19.0 to aolgithub-master * commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits) Disable unit tests that fails on PhantomJs. Fixed unit tests for adapter loader. Changed way of including analytic adapters. Added adapters in aolPartnersIds.json. Added changelog entry. Replace removed utils.extend functionality by object.assign. Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) Updated rubicon video bid endpoint in source and test files (prebid#1097) Pass through params to server (prebid#1084) Reset the list of slots to be requested between each action for pubmatic (prebid#1079) Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021) update PR template to include link to dev docs page (prebid#1075) Prebid 0.21.0 Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054) Video header bidding support to RhythmOne bidder adapter (prebid#1052) Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045) Fix adapter getSize (prebid#1064) ...

…19.0 to master * commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits) Disable unit tests that fails on PhantomJs. Fixed unit tests for adapter loader. Changed way of including analytic adapters. Added adapters in aolPartnersIds.json. Added changelog entry. Replace removed utils.extend functionality by object.assign. Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) Updated rubicon video bid endpoint in source and test files (prebid#1097) Pass through params to server (prebid#1084) Reset the list of slots to be requested between each action for pubmatic (prebid#1079) Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021) update PR template to include link to dev docs page (prebid#1075) Prebid 0.21.0 Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054) Video header bidding support to RhythmOne bidder adapter (prebid#1052) Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045) Fix adapter getSize (prebid#1064) ...

matthewlane self-assigned this Mar 28, 2017

matthewlane self-requested a review March 28, 2017 15:54

matthewlane reviewed Mar 28, 2017

View reviewed changes

Add Facebook Audience Network adapter

ddeec42

lovell force-pushed the audience-network branch from 5610a19 to ddeec42 Compare March 31, 2017 19:54

matthewlane approved these changes Mar 31, 2017

View reviewed changes

matthewlane added the LGTM label Mar 31, 2017

mkendall07 reviewed Mar 31, 2017

View reviewed changes

mkendall07 approved these changes Mar 31, 2017

View reviewed changes

mkendall07 merged commit 203fcb3 into prebid:master Apr 3, 2017

lovell deleted the audience-network branch April 3, 2017 15:03

lovell mentioned this pull request Apr 4, 2017

Document Audience Network bidder adaptor prebid/prebid.github.io#210

Merged

dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018

Add Facebook Audience Network adapter (prebid#1068)

1890105

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Facebook Audience Network adapter #1068

Add Facebook Audience Network adapter #1068

lovell commented Mar 22, 2017

mkendall07 commented Mar 24, 2017

lovell commented Mar 24, 2017

matthewlane left a comment

matthewlane Mar 28, 2017

matthewlane Mar 28, 2017 •

edited

Loading

lovell commented Mar 29, 2017

matthewlane commented Mar 29, 2017

wheresbarney commented Mar 30, 2017

matthewlane commented Mar 30, 2017

mkendall07 commented Mar 31, 2017

lovell commented Mar 31, 2017

wheresbarney commented Mar 31, 2017

lovell commented Mar 31, 2017 •

edited

Loading

matthewlane left a comment

mkendall07 Mar 31, 2017

lovell Mar 31, 2017 •

edited

Loading

mkendall07 Apr 1, 2017

mkendall07 commented Mar 31, 2017

wheresbarney commented Apr 3, 2017

mkendall07 commented Apr 3, 2017

mkendall07 commented Apr 3, 2017

Add Facebook Audience Network adapter #1068

Add Facebook Audience Network adapter #1068

Conversation

lovell commented Mar 22, 2017

Type of change

Description of change

mkendall07 commented Mar 24, 2017

lovell commented Mar 24, 2017

matthewlane left a comment

Choose a reason for hiding this comment

matthewlane Mar 28, 2017

Choose a reason for hiding this comment

matthewlane Mar 28, 2017 • edited Loading

Choose a reason for hiding this comment

lovell commented Mar 29, 2017

matthewlane commented Mar 29, 2017

wheresbarney commented Mar 30, 2017

matthewlane commented Mar 30, 2017

mkendall07 commented Mar 31, 2017

lovell commented Mar 31, 2017

wheresbarney commented Mar 31, 2017

lovell commented Mar 31, 2017 • edited Loading

matthewlane left a comment

Choose a reason for hiding this comment

mkendall07 Mar 31, 2017

Choose a reason for hiding this comment

lovell Mar 31, 2017 • edited Loading

Choose a reason for hiding this comment

mkendall07 Apr 1, 2017

Choose a reason for hiding this comment

mkendall07 commented Mar 31, 2017

wheresbarney commented Apr 3, 2017

mkendall07 commented Apr 3, 2017

mkendall07 commented Apr 3, 2017

matthewlane Mar 28, 2017 •

edited

Loading

lovell commented Mar 31, 2017 •

edited

Loading

lovell Mar 31, 2017 •

edited

Loading