socketmodule: support FreeBSD divert(4) socket #96534
Labels
Comments
vstinner
pushed a commit
that referenced
this issue
May 4, 2023
carljm
added a commit
to carljm/cpython
that referenced
this issue
May 5, 2023
* main: (61 commits) pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152) pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167) pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065) pythongh-64658: Expand Argument Clinic return converter docs (python#104175) pythonGH-103092: port `_asyncio` freelist to module state (python#104196) pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052) pythongh-104190: fix ubsan crash (python#104191) pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129) pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143) pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113) pythongh-68968: Correcting message display issue with assertEqual (python#103937) pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900) pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177) pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174) pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710) pythongh-91896: Deprecate collections.abc.ByteString (python#102096) pythongh-99593: Add tests for Unicode C API (part 2) (python#99868) pythongh-102500: Document PEP 688 (python#102571) pythongh-102500: Implement PEP 688 (python#102521) pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536) ...
|
The pull request had been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FreeBSD has divert(4) socket since previous century. Until recently it was in the namespace of PF_INET:
s = socket(PF_INET, SOCK_RAW, IPPROTO_DIVERT)This had no problems with Python's socketmodule, we just put a numeric constant in place of IPPROTO_DIVERT. And since bind(2) argument for divert(4) socket is struct sockaddr_in, luckily everything just worked.
Recently I moved the divert(4) out of PF_INET namespace, and now it should be created as:
s = socket(PF_DIVERT, SOCK_RAW, 0)Unfortunately Python's socketmodule can't support this, cause to perform socket.bind() it doesn't know how to construct sockaddr. Attempt to socket.bind() just bails out due to internal socket module error, not even coming to syscall:
This functionality is important for FreeBSD, cause we use python in our internal regression testing suite.
So, better late than never, let socketmodule recognize and support FreeBSD divert(4) socket. Making pull request in a few minutes.
The text was updated successfully, but these errors were encountered: