Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-64595: Argument Clinic: Touch source file if any output file changed #104152

Merged
merged 4 commits into from
May 5, 2023
Merged

gh-64595: Argument Clinic: Touch source file if any output file changed #104152

merged 4 commits into from
May 5, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 4, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 4, 2023
Open
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 4, 2023 •
edited
Loading

FTR, previously clinic output was written first; with this PR it is written last, as per @serhiy-storchaka's and @ncoghlan's comments, respectively #64595 (comment) and #64595 (comment).

@erlend-aasland
Copy link
Contributor Author

I consider this a non-controversial change, so I'm landing this today.

@erlend-aasland erlend-aasland enabled auto-merge (squash) May 5, 2023 12:17
@erlend-aasland erlend-aasland linked an issue May 5, 2023 that may be closed by this pull request
Argument Clinic: Touch source file if any output file changed #64595
Open
@erlend-aasland erlend-aasland merged commit 45a9e38 into python:main May 5, 2023
@erlend-aasland erlend-aasland deleted the clinic-touch-src branch May 5, 2023 12:54
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
8a78a36 
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
jbower-fb pushed a commit to jbower-fb/cpython-jbowerfb that referenced this pull request May 8, 2023
@erlend-aasland @jbower-fb
pythongh-64595: Argument Clinic: Touch source file if any output file…
d3192a2 
… changed (python#104152)
@erlend-aasland erlend-aasland mentioned this pull request Jul 5, 2023
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 5, 2023
@erlend-aasland
pythongh-64595: Fix regression in file write logic in Argument Clinic
6f5936a 
Revert the two commits that introduced the regressions:

 - pythongh-104152
 - pythongh-104507
ambv pushed a commit that referenced this pull request Jul 5, 2023
@erlend-aasland
gh-64595: Fix regression in file write logic in Argument Clinic (#106449
9d1d4f9 
)

Revert the two commits that introduced the regressions:

 - gh-104152
 - gh-104507
@erlend-aasland erlend-aasland mentioned this pull request Jul 5, 2023
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 5, 2023
@erlend-aasland
[3.12] pythongh-64595: Fix regression in file write logic in Argument…
b02430a 
… Clinic (python#106449)

Revert the two commits that introduced the regressions:

 - pythongh-104152
 - pythongh-104507

(cherry picked from commit 9d1d4f9)

Co-authored-by: Erlend Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 5, 2023
@erlend-aasland
[3.12] gh-64595: Fix regression in file write logic in Argument Clinic (
b72601e 
#106449) (#106452)

Revert the two commits that introduced the regressions:

 - gh-104152
 - gh-104507

(cherry picked from commit 9d1d4f9)
@erlend-aasland erlend-aasland removed a link to an issue Jan 17, 2024
Argument Clinic: Touch source file if any output file changed #64595
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@larryhastings larryhastings Awaiting requested review from larryhastings

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @AlexWaygood @bedevere-bot