Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104112: link from cached_property docs to method-caching FAQ #104113

Merged
merged 2 commits into from
May 4, 2023
Merged

gh-104112: link from cached_property docs to method-caching FAQ #104113

merged 2 commits into from
May 4, 2023

Conversation

carljm
Copy link
Member

@carljm carljm commented May 3, 2023 •
edited by github-actions bot
Loading

@carljm carljm requested a review from rhettinger as a code owner May 3, 2023 00:34
@bedevere-bot bedevere-bot mentioned this pull request May 3, 2023
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels May 3, 2023
hauntsaninja
hauntsaninja approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is an improvement

Doc/library/functools.rst Outdated Show resolved Hide resolved
@hauntsaninja hauntsaninja added the needs backport to 3.11 only security fixes label May 3, 2023
@carljm @hauntsaninja
Update Doc/library/functools.rst
c2c2f6c 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@carljm carljm merged commit fa86a77 into python:main May 4, 2023
@miss-islington
Copy link
Contributor

Thanks @carljm for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @carljm, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker fa86a77589a06661fcebb806d36f3a7450e2aecf 3.11

@carljm carljm deleted the cached_property_docs_2 branch May 4, 2023 22:38
@carljm carljm added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 4, 2023
@miss-islington
Copy link
Contributor

Thanks @carljm for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 4, 2023
@carljm @hauntsaninja @miss-islington
pythongh-104112: link from cached_property docs to method-caching FAQ (…
0271e1c 
…pythonGH-104113)

(cherry picked from commit fa86a77)

Co-authored-by: Carl Meyer <carl@oddbird.net>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-bot
Copy link

GH-104182 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 4, 2023
carljm added a commit that referenced this pull request May 4, 2023
@miss-islington @carljm @hauntsaninja
[3.11] gh-104112: link from cached_property docs to method-caching FAQ (
bb4369e 
GH-104113) (#104182)

gh-104112: link from cached_property docs to method-caching FAQ (GH-104113)
(cherry picked from commit fa86a77)

Co-authored-by: Carl Meyer <carl@oddbird.net>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
8a78a36 
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@13865066525 13865066525 13865066525 approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

@carljm carljm

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

we should not recommend using functools.cache on methods
5 participants
@carljm @miss-islington @bedevere-bot @hauntsaninja @13865066525