Add logic for AT90USBxx7 where needed #10203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Aug 30, 2020
tzarc
approved these changes
Aug 31, 2020
|
Issue here. if you set the MCU to the xxx7 variant, it won't compile because of the Specifically, thi issue is in <avr/iousbxx6_7.h>, line 733 (at least for 8.4.0. The at90usbxxx6 has The fix would be to change the RESET keycode name. And would absolutely be a breaking change |
fauxpark
force-pushed
the
at90usbxx7-add
branch
from
65a692b
to
39f52ba
Compare
fauxpark
commented
Sep 21, 2020
tomohisa
pushed a commit
to tomohisa/qmk_firmware
that referenced
this pull request
Sep 28, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (3643 commits) Swapparoo of bottom row keys (qmk#10277) [Keyboard] Add PloopyCo devices (qmk#7935) Keyboard update: SL40 (qmk#10445) [keyboard] Add SP-111 support (qmk#10193) Add logic for AT90USBxx7 where needed (qmk#10203) Trifecta Keymap [Docs] Wording & formatting changes in the Tapping Force Hold section of the Tap Hold page + removed trailing whitespaces (qmk#10391) `setrgb()`: Use arrow operator (qmk#10451) [Keyboard] add Percent Canoe Gen2 (qmk#10344) [Keyboard] add hannah65 by Team Mechlovin (qmk#10284) Fix Belgian sendstring properly (qmk#10444) Add VIA support for lazydesigners/the30 (qmk#10374) [Keyboard] add duckboard by doodboard (qmk#10318) Fix Belgian sendstring file (qmk#10443) [Keyboard] added Bolsa65 keyboard by FJLabs (qmk#10394) CLI/Doctor: Print QMK_HOME (qmk#10398) Add Wyvern Keyboard (qmk#10378) Adding Bear 65 Ergo Keyboard To QMK (qmk#10384) VIA Support: Gray Studio HB85 (qmk#10329) format code according to conventions [skip ci] ...
rgoulter
pushed a commit
to rgoulter/qmk_firmware
that referenced
this pull request
Oct 4, 2020
kjganz
pushed a commit
to kjganz/qmk_firmware
that referenced
this pull request
Oct 28, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting
MCU = at90usb647or1287would fail to compile, because there were no checks in mcu_selection.mk, bootloader.mk, and a few other places, that would catch it.The xx7 parts seem to be essentially identical to the xx6, however they also have the ability to act as a USB host. I don't think you can be in both modes at the same time though, but QMK doesn't have any host-mode capability anyway.
Types of Changes
Issues Fixed or Closed by This PR
Checklist