[Keyboard] Add PloopyCo devices #7935

drashna · 2020-01-18T23:54:53Z

Description

This adds QMK Firmware support for the PloopyCo Trackball and Mouse to the repo, as the first mouse/trackball. (fight me)

This uses spi_master, as well. It allows for decent amount of customization options, and some unique behavior.

Types of Changes

Keyboard (addition or update)

Checklist

My code follows the code style of this project.
[no] I have read the CONTRIBUTING document.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft · 2020-01-20T00:26:41Z

We'd have to rewrite a bunch of the makefile logic to put this in qmk_firmware/(mice|mouses)/ or something, wouldn't we?

drashna · 2020-01-20T18:22:09Z

Probably. Or at least a decent amount.

The other issue ... it would be nice to be able to have a way to disable the HID Keyboard endpoint, and just have the HID mouse endpoint.

germ · 2020-01-21T20:49:28Z

Whynot just use SHARED_ENDPOINT? That's how I get around my devices needing 3 for serial

fauxpark · 2020-01-21T21:38:50Z

@germ that doesn't disable the 6KRO interface though, their report data is just sent through the same USB endpoint, and differentiated with report IDs.
I'm not sure we want to disable it, anyway - I have a G700s and find it extremely useful to have the side buttons do Back/Forward/Ctrl+T/Ctrl+W etc. so there is definitely a use case for it on mice.

drashna · 2020-01-24T20:18:15Z

It may be nice to disable it, or at least have the option. But yeah, having the "macro" support and stuff would be nice too.

Either way, any issues with the code?

stale · 2020-04-24T15:37:41Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

stale · 2020-04-24T16:37:42Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

tzarc

Also needs a valid info.json.

keyboards/mouse/ploopyco_trackball/config.h

keyboards/mouse/ploopyco_trackball/keymaps/default/readme.md

keyboards/mouse/ploopyco_trackball/ploopyco_trackball.c

keyboards/mouse/ploopyco_trackball/ploopyco_trackball.h

keyboards/mouse/ploopyco_trackball/spi.c

keyboards/mouse/ploopyco_trackball/spi.h

keyboards/mouse/ploopyco_trackball/keymaps/default/config.h

keyboards/mouse/ploopyco_trackball/ploopyco_trackball.h

keyboards/mouse/ploopyco_trackball/rules.mk

ameyp · 2020-09-10T05:13:45Z

Has this been abandoned?

drashna · 2020-09-10T06:20:15Z

Nope. I've been meaning to work on it, and get it "up to snuff". I'll probably do that this week.

This is a WIP at this point. Most of it compiles, but the SPI commands are non-functioning as they come from Arduino, so don't exist in LUFA

But I have no idea if this is actually correct or not

keyboards/ploopyco/pmw3600.c

keyboards/ploopyco/trackball/trackball.h

keyboards/ploopyco/mouse/mouse.h

* 'master' of https://github.com/qmk/qmk_firmware: (3643 commits) Swapparoo of bottom row keys (qmk#10277) [Keyboard] Add PloopyCo devices (qmk#7935) Keyboard update: SL40 (qmk#10445) [keyboard] Add SP-111 support (qmk#10193) Add logic for AT90USBxx7 where needed (qmk#10203) Trifecta Keymap [Docs] Wording & formatting changes in the Tapping Force Hold section of the Tap Hold page + removed trailing whitespaces (qmk#10391) `setrgb()`: Use arrow operator (qmk#10451) [Keyboard] add Percent Canoe Gen2 (qmk#10344) [Keyboard] add hannah65 by Team Mechlovin (qmk#10284) Fix Belgian sendstring properly (qmk#10444) Add VIA support for lazydesigners/the30 (qmk#10374) [Keyboard] add duckboard by doodboard (qmk#10318) Fix Belgian sendstring file (qmk#10443) [Keyboard] added Bolsa65 keyboard by FJLabs (qmk#10394) CLI/Doctor: Print QMK_HOME (qmk#10398) Add Wyvern Keyboard (qmk#10378) Adding Bear 65 Ergo Keyboard To QMK (qmk#10384) VIA Support: Gray Studio HB85 (qmk#10329) format code according to conventions [skip ci] ...

* Initial Commit for Ploopyco Trackball This is a WIP at this point. Most of it compiles, but the SPI commands are non-functioning as they come from Arduino, so don't exist in LUFA * Convert SPI commands from arduino to LUFA But I have no idea if this is actually correct or not * Update keyboard readme * Clean up ploopyco trackball * Update readme * Update mouse key stuff * last minutue cleanup * Add caveat about scroll wheel * Fixup to code * Additional fixup * Add movement multiplier * Rename folders * mid changes * temp * Got it working!!!!! * Additional cleanup of code * Make unused pin calls more compact * Rotation info * Add debouncing checks * Make everything replaceable * Add info.json * Include ISP flashing info * Better handling for user customization * Reconfigure CPI stuff * fix issues with debug printing * Fix tiny scroll issue * Add and update scroll code from ploopy mouse * Update licensing * Add PloopyCo Mouse * Cleanup and layout stuff * Move common files to main folder for reuse * Increase polling rate * Update image for mouse * Apply changes from code review * Add VIA support

drashna added the keyboard label Jan 18, 2020

drashna requested a review from a team January 18, 2020 23:54

drashna force-pushed the trackball/ploopyco branch from 0a11a86 to be91332 Compare March 9, 2020 19:24

stale bot added the awaiting changes label Apr 24, 2020

zvecr added the awaiting review label Apr 24, 2020

stale bot removed the awaiting changes label Apr 24, 2020

drashna force-pushed the trackball/ploopyco branch from be91332 to bda477f Compare June 20, 2020 01:26

tzarc requested changes Jul 25, 2020

View reviewed changes

fauxpark requested changes Jul 27, 2020

View reviewed changes

keyboards/mouse/ploopyco_trackball/keymaps/default/config.h Outdated Show resolved Hide resolved

keyboards/mouse/ploopyco_trackball/ploopyco_trackball.h Outdated Show resolved Hide resolved

keyboards/mouse/ploopyco_trackball/rules.mk Outdated Show resolved Hide resolved

drashna force-pushed the trackball/ploopyco branch from bda477f to 951427b Compare August 8, 2020 08:38

drashna added 11 commits September 10, 2020 13:40

Initial Commit for Ploopyco Trackball

b5ecc60

This is a WIP at this point. Most of it compiles, but the SPI commands are non-functioning as they come from Arduino, so don't exist in LUFA

Convert SPI commands from arduino to LUFA

d6d3e35

But I have no idea if this is actually correct or not

Update keyboard readme

66ddbe1

Clean up ploopyco trackball

5fd3686

Update readme

8d6adac

Update mouse key stuff

148cf6d

last minutue cleanup

b4c072a

Add caveat about scroll wheel

0af6aef

Fixup to code

33cf7ef

Additional fixup

d21a8b3

Add movement multiplier

805904f

Cleanup and layout stuff

54e8b36

drashna changed the title ~~[Keyboard] Add PloopyCo Trackball~~ [Keyboard] Add PloopyCo devices Sep 27, 2020

drashna added 2 commits September 26, 2020 20:56

Move common files to main folder for reuse

a84fb87

Increase polling rate

6fdb1ae

jackhumbert approved these changes Sep 27, 2020

View reviewed changes

fauxpark approved these changes Sep 27, 2020

View reviewed changes

keyboards/ploopyco/pmw3600.c Outdated Show resolved Hide resolved

Update image for mouse

4cde976

fauxpark requested changes Sep 27, 2020

View reviewed changes

keyboards/ploopyco/trackball/trackball.h Outdated Show resolved Hide resolved

keyboards/ploopyco/mouse/mouse.h Outdated Show resolved Hide resolved

drashna added 2 commits September 26, 2020 21:43

Apply changes from code review

177cff0

Add VIA support

674c2e0

fauxpark approved these changes Sep 27, 2020

View reviewed changes

drashna merged commit fbdc65e into qmk:master Sep 27, 2020

drashna deleted the trackball/ploopyco branch October 6, 2020 17:49

drashna mentioned this pull request Oct 6, 2020

Add PloopyCo devices the-via/keyboards#354

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Keyboard] Add PloopyCo devices #7935

[Keyboard] Add PloopyCo devices #7935

drashna commented Jan 18, 2020 •

edited

Loading

noroadsleft commented Jan 20, 2020

drashna commented Jan 20, 2020 •

edited

Loading

germ commented Jan 21, 2020

fauxpark commented Jan 21, 2020

drashna commented Jan 24, 2020

stale bot commented Apr 24, 2020

stale bot commented Apr 24, 2020

tzarc left a comment

ameyp commented Sep 10, 2020

drashna commented Sep 10, 2020

[Keyboard] Add PloopyCo devices #7935

[Keyboard] Add PloopyCo devices #7935

Conversation

drashna commented Jan 18, 2020 • edited Loading

Description

Types of Changes

Checklist

noroadsleft commented Jan 20, 2020

drashna commented Jan 20, 2020 • edited Loading

germ commented Jan 21, 2020

fauxpark commented Jan 21, 2020

drashna commented Jan 24, 2020

stale bot commented Apr 24, 2020

stale bot commented Apr 24, 2020

tzarc left a comment

Choose a reason for hiding this comment

ameyp commented Sep 10, 2020

drashna commented Sep 10, 2020

drashna commented Jan 18, 2020 •

edited

Loading

drashna commented Jan 20, 2020 •

edited

Loading