-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add keyboard support for duckboard #10318
Conversation
Adding duckboard support to QMK
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Update code per review
folder name errod
Sorry for the mistakes. This is my first time contributing and there is a lot to learn, clearly. Thank you in advance for the time and effort! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This board is also missing an info.json.
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
comments applied, and I added info.json! |
the firmware compiles fine on my end, I'm not sure why it's failing the checks |
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Thank you guys for the reviews! Is there something else I need to do at this point? |
Nope; looks good, thanks! |
* 'master' of https://github.com/qmk/qmk_firmware: (3643 commits) Swapparoo of bottom row keys (qmk#10277) [Keyboard] Add PloopyCo devices (qmk#7935) Keyboard update: SL40 (qmk#10445) [keyboard] Add SP-111 support (qmk#10193) Add logic for AT90USBxx7 where needed (qmk#10203) Trifecta Keymap [Docs] Wording & formatting changes in the Tapping Force Hold section of the Tap Hold page + removed trailing whitespaces (qmk#10391) `setrgb()`: Use arrow operator (qmk#10451) [Keyboard] add Percent Canoe Gen2 (qmk#10344) [Keyboard] add hannah65 by Team Mechlovin (qmk#10284) Fix Belgian sendstring properly (qmk#10444) Add VIA support for lazydesigners/the30 (qmk#10374) [Keyboard] add duckboard by doodboard (qmk#10318) Fix Belgian sendstring file (qmk#10443) [Keyboard] added Bolsa65 keyboard by FJLabs (qmk#10394) CLI/Doctor: Print QMK_HOME (qmk#10398) Add Wyvern Keyboard (qmk#10378) Adding Bear 65 Ergo Keyboard To QMK (qmk#10384) VIA Support: Gray Studio HB85 (qmk#10329) format code according to conventions [skip ci] ...
* Adding duckboard to QMK Adding duckboard support to QMK * added duckboard under doodboard * changed debouncing delay to debounce * Update keyboards/doodboard/duckboard/config.h * Update keyboards/doodboard/duckboard/config.h * Update keyboards/doodboard/duckboard/kb.h * Update keyboards/doodboard/duckboard/keymaps/default/keymap.c * Update keyboards/doodboard/duckboard/rules.mk * Update keyboards/doodboard/duckboard/kb.h * Update keyboards/doodboard/duckboard/kb.c * Update code per review Update code per review * folder name errod folder name errod * Update keyboards/doodboard/duckboard/config.h * Update keyboards/doodboard/duckboard/rules.mk * Update keyboards/doodboard/duckboard/rules.mk * Update keyboards/doodboard/duckboard/config.h * Create info.json * Update keyboards/doodboard/duckboard/duckboard.h * Update keyboards/doodboard/duckboard/info.json * Update keyboards/doodboard/duckboard/info.json * Update keyboards/doodboard/duckboard/duckboard.h * Update keyboards/doodboard/duckboard/readme.md
* Adding duckboard to QMK Adding duckboard support to QMK * added duckboard under doodboard * changed debouncing delay to debounce * Update keyboards/doodboard/duckboard/config.h * Update keyboards/doodboard/duckboard/config.h * Update keyboards/doodboard/duckboard/kb.h * Update keyboards/doodboard/duckboard/keymaps/default/keymap.c * Update keyboards/doodboard/duckboard/rules.mk * Update keyboards/doodboard/duckboard/kb.h * Update keyboards/doodboard/duckboard/kb.c * Update code per review Update code per review * folder name errod folder name errod * Update keyboards/doodboard/duckboard/config.h * Update keyboards/doodboard/duckboard/rules.mk * Update keyboards/doodboard/duckboard/rules.mk * Update keyboards/doodboard/duckboard/config.h * Create info.json * Update keyboards/doodboard/duckboard/duckboard.h * Update keyboards/doodboard/duckboard/info.json * Update keyboards/doodboard/duckboard/info.json * Update keyboards/doodboard/duckboard/duckboard.h * Update keyboards/doodboard/duckboard/readme.md
Adding duckboard support to QMK
Description
Adding support for Duckboard to QMK.
Added new folder "duckboard" under keyboard.
Added config.h / kb.c / kb.h / Makefile / rules.mk / Keymap.c to relevant directory.
Types of Changes
Issues Fixed or Closed by This PR
Checklist