Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hannah65 PCB #10284

Merged
merged 21 commits into from
Sep 26, 2020
Merged

Add hannah65 PCB #10284

merged 21 commits into from
Sep 26, 2020

Conversation

mechlovin
Copy link
Contributor

Description

Add hannah65 PCB.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechlovin mechlovin mentioned this pull request Sep 11, 2020
Merged
6 tasks
@drashna drashna requested a review from a team September 20, 2020 22:49
@drashna drashna requested review from noroadsleft, a team, Erovia and yanfali September 20, 2020 22:51
fauxpark
fauxpark requested changes Sep 21, 2020
View reviewed changes
keyboards/mechlovin/hannah65/rules.mk Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Sep 22, 2020
View reviewed changes
keyboards/mechlovin/hannah65/mechlovin9/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah65/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah65/rules.mk Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah65/rev1/keymaps/via/keymap.c Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Sep 23, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

keyboards/mechlovin/hannah65/mechlovin9/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah65/mechlovin9/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah65/mechlovin9/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah65/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah65/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah65/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah65/rev1/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah65/rev1/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah65/rev1/info.json Outdated Show resolved Hide resolved
mechlovin and others added 9 commits September 24, 2020 13:52
@mechlovin
update
33eb244
@mechlovin @noroadsleft
Update keyboards/mechlovin/hannah65/mechlovin9/info.json
9d5ae33 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@mechlovin @noroadsleft
Update keyboards/mechlovin/hannah65/mechlovin9/info.json
4374cfd 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@mechlovin @noroadsleft
Update keyboards/mechlovin/hannah65/mechlovin9/readme.md
6d71973 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@mechlovin @noroadsleft
Update keyboards/mechlovin/hannah65/readme.md
b49ab03 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@mechlovin @noroadsleft
Update keyboards/mechlovin/hannah65/rev1/info.json
bc586a5 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@mechlovin @noroadsleft
Update keyboards/mechlovin/hannah65/rev1/info.json
b0061ee 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@mechlovin @noroadsleft
Update keyboards/mechlovin/hannah65/rev1/rev1.h
664c15c 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@mechlovin @noroadsleft
Update keyboards/mechlovin/hannah65/rev1/rev1.h
57a8217 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@noroadsleft
Copy link
Member

One review comment outstanding.

@mechlovin
Copy link
Contributor Author

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

Its new for me. Thank you

mechlovin and others added 2 commits September 24, 2020 18:56
@mechlovin @noroadsleft
Update keyboards/mechlovin/hannah65/mechlovin9/info.json
bdf50de 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@mechlovin
update
7b9a88d
mechlovin and others added 2 commits September 26, 2020 09:56
@mechlovin @noroadsleft
Update keyboards/mechlovin/hannah65/mechlovin9/info.json
0b04559 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@mechlovin @noroadsleft
Update keyboards/mechlovin/hannah65/mechlovin9/info.json
6734bf5 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@noroadsleft noroadsleft merged commit c4cc697 into qmk:master Sep 26, 2020
@noroadsleft
Copy link
Member

Thanks!

tomohisa pushed a commit to tomohisa/qmk_firmware that referenced this pull request Sep 28, 2020
Merge branch 'master' of https://github.com/qmk/qmk_firmware
8c2197d 
* 'master' of https://github.com/qmk/qmk_firmware: (3643 commits)
  Swapparoo of bottom row keys (qmk#10277)
  [Keyboard] Add PloopyCo devices (qmk#7935)
  Keyboard update: SL40 (qmk#10445)
  [keyboard] Add SP-111 support (qmk#10193)
  Add logic for AT90USBxx7 where needed (qmk#10203)
  Trifecta Keymap
  [Docs] Wording & formatting changes in the Tapping Force Hold section of the Tap Hold page + removed trailing whitespaces (qmk#10391)
  `setrgb()`: Use arrow operator (qmk#10451)
  [Keyboard] add Percent Canoe Gen2 (qmk#10344)
  [Keyboard] add hannah65 by Team Mechlovin (qmk#10284)
  Fix Belgian sendstring properly (qmk#10444)
  Add VIA support for lazydesigners/the30 (qmk#10374)
  [Keyboard] add duckboard by doodboard (qmk#10318)
  Fix Belgian sendstring file (qmk#10443)
  [Keyboard] added Bolsa65 keyboard by FJLabs (qmk#10394)
  CLI/Doctor: Print QMK_HOME (qmk#10398)
  Add Wyvern Keyboard (qmk#10378)
  Adding Bear 65 Ergo Keyboard To QMK (qmk#10384)
  VIA Support: Gray Studio HB85 (qmk#10329)
  format code according to conventions [skip ci]
  ...
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@mechlovin @rgoulter
[Keyboard] add hannah65 by Team Mechlovin (qmk#10284)
c7c41ce 
* add hannah65

* add iso layout, ansi layout

* Update readme.md

* add mechlovin9

* update

* update

* update

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* Update keyboards/mechlovin/hannah65/mechlovin9/readme.md

* Update keyboards/mechlovin/hannah65/readme.md

* Update keyboards/mechlovin/hannah65/rev1/info.json

* Update keyboards/mechlovin/hannah65/rev1/info.json

* Update keyboards/mechlovin/hannah65/rev1/rev1.h

* Update keyboards/mechlovin/hannah65/rev1/rev1.h

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* update

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@mechlovin
[Keyboard] add hannah65 by Team Mechlovin (qmk#10284)
d73e508 
* add hannah65

* add iso layout, ansi layout

* Update readme.md

* add mechlovin9

* update

* update

* update

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* Update keyboards/mechlovin/hannah65/mechlovin9/readme.md

* Update keyboards/mechlovin/hannah65/readme.md

* Update keyboards/mechlovin/hannah65/rev1/info.json

* Update keyboards/mechlovin/hannah65/rev1/info.json

* Update keyboards/mechlovin/hannah65/rev1/rev1.h

* Update keyboards/mechlovin/hannah65/rev1/rev1.h

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* update

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@Erovia Erovia Awaiting requested review from Erovia

@yanfali yanfali Awaiting requested review from yanfali

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mechlovin @noroadsleft @drashna @fauxpark