Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying the TransitionCallback and FeedbackCallback outside of initGoal #98

Open
finger563 opened this issue Mar 26, 2018 · 1 comment

Comments

@finger563
Copy link

RIght now the TransitionCallback and FeedbackCallback must be provided every time initGoal is called in order for the callbacks to be called. I'm opening this issue for a PR I will make which will add support for configuring those callbacks outside of the initGoal call.

@finger563
Copy link
Author

finger563 commented Apr 3, 2018

Would mirror the structure of the SimpleActionSever which allows

void registerGoalCallback (boost::function< void()> cb)
void registerPreemptCallback (boost::function< void()> cb)

so that the SimpleActionClient would have methods

void registerDoneCallback (SimpleDoneCallback cb)
void registerActiveCallback (SimpleActiveCallback cb)
void registerFeedbackCallback (SimpleFeedbackCallback cb)

finger563 added a commit to rosmod/actionlib that referenced this issue Apr 3, 2018
finger563 added a commit to rosmod/actionlib that referenced this issue Apr 3, 2018
finger563 added a commit to rosmod/actionlib that referenced this issue Apr 3, 2018
finger563 added a commit to rosmod/actionlib that referenced this issue Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant