Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in statistics decision making if one should publish #1625

Merged
merged 1 commit into from
Feb 26, 2019
Merged

fixed bug in statistics decision making if one should publish #1625

merged 1 commit into from
Feb 26, 2019

Conversation

wentz89
Copy link
Contributor

@wentz89 wentz89 commented Feb 21, 2019

No description provided.

@dirk-thomas
Copy link
Member

@wentz89 Please provide at least a minimal description when creating a ticket. In this case the PR aims to fix #1621.

@kejxu
Copy link
Contributor

kejxu commented Feb 22, 2019

great catch! time lapsed = 1 / frequency

I recognized that pub_frequency_ is a double value, which doesn't make sense

why not, frequency could be a floating point number. and it (implicitly) makes sure 1 / frequency yields the correct value

@wentz89
Copy link
Contributor Author

wentz89 commented Feb 26, 2019

@kejxu well yes, but actually no ;). I should have written "it doesn't make sense in this case" cause:

  1. the program evaluats a time + Duration(frequenzy), when it should be time + Duration(rate)
  2. (but this is my opinion) One usually say this publisher should have a frequency of 100 Hz or 1 Hz or 10 Hz. One never hear 10,5 Hz or 100,7 Hz should be the frequency, therefore it could be an integer value

@dirk-thomas
Copy link
Member

Thanks for patch.

@dirk-thomas dirk-thomas merged commit 943f373 into ros:melodic-devel Feb 26, 2019
@dirk-thomas
Copy link
Member

@wentz89 @kejxu Please see #1577 for a more complete patch for this problem. It would be great if either of you could try that patch and comment on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants