Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows][melodic-devel] Fixed test code build errors (cpp projects). #1723

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Jun 10, 2019

Added missing header inclusion to fix test code build errors on Windows build. Verified in https://aka.ms/ros project.

@seanyen
Copy link
Contributor Author

seanyen commented Aug 8, 2019

@dirk-thomas I noticed you are starting to process open pull requests for ros_comm. And hope you get a chance to take a look #1723 and #1725, so I can swap to use the upstream version ros_comm for ROS on Windows.

(There are some other test code fixes pull requests but we can review it later.)

@dirk-thomas
Copy link
Member

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 5cd3e76 into ros:melodic-devel Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants