Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ rust-analyzer #101759

Merged
merged 31 commits into from
Sep 13, 2022
Merged

⬆️ rust-analyzer #101759

merged 31 commits into from
Sep 13, 2022

Commits on Aug 31, 2022

  1. Allow multi-part inlay hint labels with location links

    Jonas Schievink committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    241807d View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Configuration menu
    Copy the full SHA
    fcc6133 View commit details
    Browse the repository at this point in the history
  2. Extract shared logic

    ice1000 committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    79e5c36 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    277df02 View commit details
    Browse the repository at this point in the history
  4. Address comments

    ice1000 committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    37e20de View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a695e90 View commit details
    Browse the repository at this point in the history
  6. Fix test

    ice1000 committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    68eabf1 View commit details
    Browse the repository at this point in the history
  7. Fmt

    ice1000 committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    364d9c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Insert whitespaces into static & const bodies if they are expanded fr…

    …om macro on hover
    
    Macro expansion erases whitespace information, and so we end with invalid Rust code.
    ChayimFriedman2 committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    e295f0c View commit details
    Browse the repository at this point in the history
  2. Do not insert a newline after ; if the next token is a }

    This creates double newline.
    ChayimFriedman2 committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    26b5f1f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    748567c View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Configuration menu
    Copy the full SHA
    265c75c View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#13091 - ice1k:hey, r=Veykril

    Remove type alias definition on inline
    
    Fix rust-lang#13079
    bors committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    a1c2653 View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#13139 - Austaras:enum, r=Veykril

    Suggest struct when completing enum
    
    closes rust-lang#13107
    bors committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4790916 View commit details
    Browse the repository at this point in the history
  4. Auto merge of rust-lang#13185 - ChayimFriedman2:insert-ws-in-static-c…

    …onst-macro, r=Veykril
    
    fix: Insert whitespaces into static & const bodies if they are expanded from macro on hover
    
    Partially fixes rust-lang#13143.
    
    To resolve the other part we need to expand macros in unevaluated static & const bodies, and I'm not sure we want to. If for example it includes a call to `assert!()`, expanding it will lead to worse hover.
    bors committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    5be2e65 View commit details
    Browse the repository at this point in the history
  5. Auto merge of rust-lang#13192 - lowr:fix/dyn-sort-all-bounds, r=Veykril

    fix: sort all bounds on trait object types
    
    Fixes rust-lang#13181
    
    rust-lang#12793 allowed different ordering of trait bounds in trait object types but failed to account for the ordering of projection bounds. I opted for sorting all the bounds at once rather than splitting them into `SmallVec`s so it's easier to do the same thing for other bounds when we have them.
    bors committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    6dfd8ae View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Use proc-macro-srv from sysroot in rust-project.json

    Joseph Ryan committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5d126a1 View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#13200 - P1n3appl3:sysroot, r=Veykril

    Use proc-macro-srv from sysroot in rust-project.json workspaces
    
    This was discussed [on zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/.60sysroot.60.20vs.20.60sysroot_src.60.20for.20.60rust-project.2Ejson.60.3F/near/293023920), basically in `rust-project.json` workspaces RA doesn't respect the `sysroot` setting when picking which `proc-macro-srv` to launch, and this causes abi mismatches in practice.
    
    This is the simple fix that `@Veykril` suggested, and I've verified that it works on Fuchsia by inspecting the cmdline with `pgrep rust-analyzer | xargs ps -fp` to check that it's using the `proc-macro-srv` from our prebuilts which matches the `sysroot` specified in our `rust-project.json`.
    
    Can this be merged as is, or do we need to add tests that exercise this?
    bors committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6909556 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Make clicking closing brace hint go to the opening brace

    Jonas Schievink committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    064c9ef View commit details
    Browse the repository at this point in the history
  2. Update crates/rust-analyzer/src/to_proto.rs

    Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
    jonas-schievink and Veykril authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    c4eadab View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#13158 - jonas-schievink:inlayhint-links, r=jo…

    …nas-schievink
    
    feat: make clicking a closing brace inlay hint go to the opening brace
    bors committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    4e1a3da View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c7fefd5 View commit details
    Browse the repository at this point in the history
  5. fix: removed swap file

    randomicon00 committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    bd3feea View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Auto merge of rust-lang#13207 - randomicon00:semicol#13196, r=lnicola

    fix: add semicolon completion to mod
    
    fixes rust-lang#13196
    
    `@Veykril` The tests are passing. I added one specifically for this case.
    bors committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    b7e8b9a View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. Configuration menu
    Copy the full SHA
    54fe5b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. Configuration menu
    Copy the full SHA
    b843b88 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd65588 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae57150 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    73d7599 View commit details
    Browse the repository at this point in the history
  5. Auto merge of rust-lang#13214 - SpencerSharkey:ubuntu-container-build…

    …, r=lnicola
    
    Build release artifact against older Glibc
    
    When GitHub [deprecated Ubuntu 18.04](https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/) runners, rust-analyzer was forced to bump runners to 20.04 which includes an updated Glib. This renders RA incompatible with the still popular Ubuntu 18.04 and other slightly older distro versions.
    
    Until a deprecation plan is announced on RA's side, I propose binaries shall be built against older glibc to maintain compatibility.
    
    This PR changes the Release CI workflow to build the `linux-x64/x86_64-unknown-linux-gnu` release in an Ubuntu 18.04 container.
    
    Fixes rust-lang#13081 and rust-lang#13085
    bors committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    2e9f120 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. ⬆️ rust-analyzer

    lnicola committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    c93b070 View commit details
    Browse the repository at this point in the history