…ts except for pats in fn bodies

… traits

…m-ra

minor: polish warning msg

sorry for this 😅

![PixPin_2024-02-04_18-33-23](https://github.com/rust-lang/rust-analyzer/assets/71162630/9aaa49d7-34f4-4c78-b91c-e85550252e25)

…m-rust

internal: Sync from downstream

…lnicola

Remove unused Subtree::visit_ids function

Completely unused, nothing else even shows up when searching for `visit_ids`.

…mprovements, r=lnicola

internal: even more `tracing`

As part of profiling completions, I added some additional spans and moved `TyBuilder::subst_for_def` closer to its usage site (the latter had a small impact on completion performance. Thanks for the tip, Lukas!)

Swap Subtree::token_trees from Vec to boxed slice

Performs one of the optimizations suggested in rust-lang#16325, but a little bit more. Boxed slices guarantee `shrink_to_fit` aswell as saving a pointer width as no capacity has to be stored.

Most of the diff is:
- Changing `vec![]` to `Box::new([])`
- Changing initialize -> fill into fill -> into_boxed_slice
- Working around the lack of an owned iterator or automatic iteration over a `Box<[T]>`

I would like to use my own crate, [small-fixed-array](https://lib.rs/small-fixed-array), although I understand if it isn't mature enough for this. If I'm given the go ahead, I can rework this PR to use it instead.

…kril

fix: emit parser error for missing argument list

close rust-lang/rust-analyzer#16362

internal: Lint debug prints and disallowed types with clippy

minor: remove clones

internal: Update rustc_pattern_analysis dependency

Just bumping the dependency, as I've been making API changes over on the rustc side. More API changes incoming in the coming weeks.

One benefit of this: we no longer abort in the `DeconstructedPat: Debug` impl, which means we can use `tracing` to investigate issues.

internal: run Clippy on Windows

CC rust-lang/rust-analyzer#16413 (comment)

![image](https://github.com/rust-lang/rust-analyzer/assets/308347/3bb4c06b-6388-4b1e-81f5-f0c2fbc3302c)

minor: Add `lete` to postfix completion list

Move salsa fork in-tree

No one else is supposed to rely on it anyways, this makes it easier to edit.

Optimize input queries that take no arguments

There is no point in having a hashmap and extra lock for this, it is always only a single value. This might speed up some things by a tiny bit for our crate graph query.

minor: bump `paths-filter`

Fixes a Node version warning.

…=lnicola

Remove `ffi_returns_twice` references

This feature has just been [removed](rust-lang#120502)

fix: Fix tuple structs not rendering visibility in their fields

Fixes rust-lang/rust-analyzer#16508

feat: Allow cargo check to run on only the current package

cc rust-lang/rust-analyzer#13336, rust-lang/rust-analyzer#12882

Previously, when parsing an argument list with a missing argument (e.g.,
`(a, , b)` in `foo(a, , b)`), the parser would stop upon an unexpected
token (at the second comma in the example), resulting in an incorrect
parse tree.

This commit improves error handling in such cases, ensuring a more
accurate parse tree is built.

fix: Recover from missing argument in call expressions

Previously, when parsing an argument list with a missing argument (e.g., `(a, , b)` in `foo(a, , b)`), the parser would stop upon an unexpected token (at the second comma in the example), resulting in an incorrect parse tree.

This commit improves error handling in such cases, ensuring a more accurate parse tree is built.

---

Fixes rust-lang/rust-analyzer#15683.

fix: waker_getters tracking issue from 87021 for 96992.

I was directed to make the fix here by this comment rust-lang#118960 (comment).

Better error message for when proc-macros have not yet been built

Closes rust-lang/rust-analyzer#16331

feat: Add break and return postfix keyword completions

…stic, r=Veykril

feat: Add "unnecessary else" diagnostic and fix

Fixes rust-lang#9457

…agnostic, r=Veykril

feat: Add incorrect case diagnostics for traits and their associated items

Updates incorrect case diagnostic to:
- Check traits and their associated items
- Ignore trait implementations except for patterns in associated function bodies

Also cleans up `hir-ty::diagnostics::decl_check` a bit (mostly to make it a bit more DRY and easier to maintain)

Also fixes: rust-lang#8675 and fixes: rust-lang#8225

fix: preserve where clause when builtin derive

Closes rust-lang#16432.

…=Veykril

Remove unnecessary `.as_ref()` in generate getter assist

Resolves rust-lang#12389

…tests

…tic, r=Veykril

feat: Add diagnostic with fix to replace trailing `return <val>;` with `<val>`

Works for functions and closures.
Ignores desugared return expressions (e.g. from desugared try operators).

Fixes: rust-lang#10970
Completes: rust-lang#11020

…tting.

…repo-mode, r=Veykril

feature: Create `UnindexedProject` notification to be sent to the client

(Note that this branch contains commits from rust-lang/rust-analyzer#15830, which I'll rebase atop of as needed.)

Based on the discussion in rust-lang/rust-analyzer#15837, I've added a notification and off-by-default toggle to send that notification from `handle_did_open_text_document`. I'm happy to rename/tweak this as needed.

I've been using this for a little bit, and it does seem to cause a little bit more indexing/work in rust-analyzer, but it's something that I'll profile as needed, I think.

`make::impl_` no longer merges generic params and args in order to be in line
with `make::impl_`, which doesn't do it either.

Shortcut version of `make::expr_path(make::path_unqualified(make::path_segment_self()))`

Needed to recreate the behavior of `generate_new` addding the `new` method at the start of the impl