Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Error Format for E0091 and E0092 #35528

Merged
merged 2 commits into from
Aug 12, 2016
Merged

Update Error Format for E0091 and E0092 #35528

merged 2 commits into from
Aug 12, 2016

Conversation

stephen-lazaro
Copy link
Contributor

@stephen-lazaro stephen-lazaro commented Aug 8, 2016 •
edited
Loading

Addresses #35228 and #35229 as part of #35233.

Please let me know if there are any issues; first time contributor.

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@stephen-lazaro
Copy link
Contributor Author

Apologies, typo seems to have messed up the auto-assignment to @jonathandturner.

This was referenced Aug 8, 2016
Closed
Closed
@sophiajt
Copy link
Contributor

sophiajt commented Aug 8, 2016

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 8, 2016

📌 Commit da8fed5 has been approved by jonathandturner

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
@steveklabnik
Rollup merge of rust-lang#35528 - Vassah:master, r=jonathandturner
5847faa 
Update Error Format for E0091 and E0092

Addresses [rust-lang#35228](rust-lang#35228) and [rust-lang#35229](rust-lang#35229) as part of [rust-lang#35233](rust-lang#35233).

Please let me know if there are any issues; first time contributor.

r? @jonathandturner
@steveklabnik steveklabnik mentioned this pull request Aug 10, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 10, 2016
Rollup merge of rust-lang#35528 - Vassah:master, r=jonathandturner
46af590 
Update Error Format for E0091 and E0092

Addresses [rust-lang#35228](rust-lang#35228) and [rust-lang#35229](rust-lang#35229) as part of [rust-lang#35233](rust-lang#35233).

Please let me know if there are any issues; first time contributor.

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 10, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 11, 2016
Rollup merge of rust-lang#35528 - Vassah:master, r=jonathandturner
0283443 
Update Error Format for E0091 and E0092

Addresses [rust-lang#35228](rust-lang#35228) and [rust-lang#35229](rust-lang#35229) as part of [rust-lang#35233](rust-lang#35233).

Please let me know if there are any issues; first time contributor.

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 11, 2016
Merged
bors added a commit that referenced this pull request Aug 11, 2016
@bors
Auto merge of #35592 - jonathandturner:rollup, r=jonathandturner
8787a12 
Rollup of 23 pull requests

- Successful merges: #35279, #35331, #35358, #35375, #35445, #35448, #35482, #35486, #35505, #35528, #35530, #35532, #35536, #35537, #35541, #35552, #35554, #35555, #35557, #35562, #35565, #35569, #35576
- Failed merges: #35395, #35415, #35563
@bors bors merged commit da8fed5 into rust-lang:master Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephen-lazaro @rust-highfive @sophiajt @bors @pnkfelix