Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated E0433 to new error message. (no bonus) #35536

Merged
merged 2 commits into from
Aug 12, 2016

Conversation

hank-der-hafenarbeiter
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 8, 2016

Thanks for the PR!

Be sure to update the corresponding unit test. I talk about some ways you can do this in the blog post

@hank-der-hafenarbeiter
Copy link
Contributor Author

Unit testing checks out for me though. There is no "compile-fail/E0433.rs" and "compile-fail/derived-errors/issue-31997-1.rs" gives an ok on my end.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 9, 2016

@hank-der-hafenarbeiter - There's a quirk in the tester that won't check the labels if there isn't at least one NOTE in the unit test. I talk about this quirk in the Extra Credit section of the blog post.

You can update the test file you have with at least one NOTE to test the label you added.

@hank-der-hafenarbeiter
Copy link
Contributor Author

Oh didn't see that! I'll check tomorrow. it's past 2 am around here gotta get some sleep first.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 9, 2016

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 9, 2016

📌 Commit b5ead00 has been approved by jonathandturner

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
…athandturner

Updated E0433 to new error message. (no bonus)

Part of rust-lang#35345
r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 10, 2016
…athandturner

Updated E0433 to new error message. (no bonus)

Part of rust-lang#35345
r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 11, 2016
…athandturner

Updated E0433 to new error message. (no bonus)

Part of rust-lang#35345
r? @jonathandturner
bors added a commit that referenced this pull request Aug 11, 2016
@bors bors merged commit b5ead00 into rust-lang:master Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants