Rollup of 33 pull requests #35571
Closed
Rollup of 33 pull requests #35571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of changes to how Rust acquires randomness HashMap is not guaranteed to be DoS resistant. This commit reflects these changes in the docs themselves and provides an alternative method to creating a hash that is resistant if needed.
Added some extra code to check for the appropriate ending for numbers == 1 vs. not 1 in error messages. Added an extra test so that the plural suffix is seen and exercised.
Add the unstable `:` colon and `<-` inplace operators.
- Fix note message, fix tests.
When using Point { x: 0, y: 0 } and showing pattern matching decomposing
x and y individually its hard to understand. By using a different value
for x and a different value for y it is more clear.
…klabnik
book: update example patterns to be more clear
When using Point { x: 0, y: 0 } and showing pattern matching decomposing
x and y individually its hard to understand. By using a different value
for x and a different value for y it is more clear.
book: fix formatting of module layout example
Update E0214 to the new error format Part of rust-lang#35233 Addresses rust-lang#35383 "r? @jonathandturner
…ndturner Fix E0132 error display Error and note now use the same span. r? @jonathandturner
Remove unnecessary `main` functions in doc examples.
Shrink E0205 span label to the trait being implemented Part of rust-lang#35233. Extension of rust-lang#35468. Closes rust-lang#35382. r? @GuillaumeGomez
…rner Shrink span to variant discriminant expression for E0081 Part of rust-lang#35233. Extension of rust-lang#35353. Fixes rust-lang#35224. r? @jonathandturner
…t, r=jonathandturner Updated E0026 to new format. Part of rust-lang#35233. Fixes rust-lang#35497. r? @jonathandturner
Add test for issue rust-lang#29053 This PR adds a test for rust-lang#29053 (currently fails on stage 0, but works with stage 1, as it should). Fixes rust-lang#29053
…nathandturner Updated Error mesage to new format for E0221 Part of rust-lang#35386 r? @jonathandturner
…ormat, r=jonathandturner Update E0162 to the new format Part of rust-lang#35233. Fixes rust-lang#35268. r? @jonathandturner
Update E0033 to the new error format Part of rust-lang#35233 Addresses rust-lang#35498 "r? @jonathandturner
Update Error Format for E0091 and E0092 Addresses [rust-lang#35228](rust-lang#35228) and [rust-lang#35229](rust-lang#35229) as part of [rust-lang#35233](rust-lang#35233). Please let me know if there are any issues; first time contributor. r? @jonathandturner
Update E0008 and E0007 to new format Part of rust-lang#35233 A fix for rust-lang#35496 r? @jonathandturner
…ndturner Do not span across nodes for E0004 Part of rust-lang#35233. Fixes rust-lang#35529. r? @arielb1
…athandturner Updated E0433 to new error message. (no bonus) Part of rust-lang#35345 r? @jonathandturner
Update E0038 to the new error format Part of rust-lang#35233 Addresses rust-lang#35500 "r? @jonathandturner This doesn't compile yet, and I need help. In my naive solution, adding the span label makes our error message a mutable `errors::DiagnosticBuilder` pointer. ```bash python src/bootstrap/bootstrap.py --step check-cfail E0038 --stage 1 ``` ``` Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) Building stage0 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) Compiling rustc v0.0.0 (file:///home/nash/code/rust/src/librustc) src/librustc/traits/error_reporting.rs:735:9: 735:12 error: mismatched types [E0308] src/librustc/traits/error_reporting.rs:735 err ^~~ src/librustc/traits/error_reporting.rs:735:9: 735:12 help: run `rustc --explain E0308` to see a detailed explanation src/librustc/traits/error_reporting.rs:735:9: 735:12 note: expected type `core::option::Option<errors::DiagnosticBuilder<'tcx>>` src/librustc/traits/error_reporting.rs:735:9: 735:12 note: found type `core::option::Option<&mut errors::DiagnosticBuilder<'_>>` error: aborting due to previous error error: Could not compile `rustc`. To learn more, run the command again with --verbose. command did not execute successfully: "/home/nash/code/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "-j" "4" "--target" "x86_64-unknown-linux-gnu" "--release" "--features" " jemalloc" "--manifest-path" "/home/nash/code/rust/src/rustc/Cargo.toml" expected success, got: exit code: 101 ```
…athandturner Updated E0045 to new error format (no bonus) Part of rust-lang#35501 r? @jonathandturner
Update error message E0384 to new format Part of rust-lang#35233 Fixes rust-lang#35184 r? @jonathandturner
Add tracking issue for `String::insert_str`
…t, r=jonathandturner E0128 update error format Fixes rust-lang#35508 Part of rust-lang#35233 r? @jonathandturner
E0263 updated to new format. Fixes rust-lang#35518. Part of rust-lang#35233. r? @jonathandturner
Remove redundant `&mut ref mut` in doc for Result::as_mut() While a good example of how `&mut ref mut` is a no-op, I don't think we should show that here :) See https://users.rust-lang.org/t/mnemonic-for-reading-qualifiers/6853 r? @steveklabnik
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 0db7846 has been approved by |
|
oh wait, i did not see #35525 due to lack of priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainfunctions in doc examples. #35482, Shrink E0205 span label to the trait being implemented #35484, Shrink span to variant discriminant expression for E0081 #35486, Updated E0026 to new format. #35504, Add test for issue #29053 #35505, Updated Error mesage to new format for E0221 #35507, Update E0162 to the new format #35524, Update E0033 to the new error format #35526, Update Error Format for E0091 and E0092 #35528, Update E0008 and E0007 to new format #35530, Do not span across nodes for E0004 #35532, Updated E0433 to new error message. (no bonus) #35536, Update E0038 to the new error format #35537, Updated E0045 to new error format (no bonus) #35541, Update error message E0384 to new format #35552, Add tracking issue forString::insert_str#35554, E0128 update error format #35555, E0263 updated to new format. #35557, Remove redundant&mut ref mutin doc for Result::as_mut() #35562