Rollup of 10 pull requests #61379

Centril · 2019-05-30T22:24:50Z

Successful merges:

error: remove StringError from Debug output #60897 (error: remove StringError from Debug output)
Miri: give machine the chance to tag all allocations #61278 (Miri: give machine the chance to tag all allocations)
Speed up Azure CI installing Windows dependencies #61304 (Speed up Azure CI installing Windows dependencies)
Set ellipsis_inclusive_range_patterns lint to warn #61342 (Set ellipsis_inclusive_range_patterns lint to warn)
Add regression test for const generics ICE #61344 (Add regression test for const generics ICE)
Fix links in Deref documentation #61359 (Fix links in Deref documentation)
Stabilize iter_nth_back feature #61363 (Stabilize iter_nth_back feature)
Fixed lifetime misspelling #61369 (Fixed lifetime misspelling)
Migrate some books to mdbook version 0.2 #61372 (Migrate some books to mdbook version 0.2)
Explicitly suggest 'type_ascription' feature #61374 (Explicitly suggest 'type_ascription' feature)

Failed merges:

Seeing `StringError("something something")` in debug output can cause someone to think there was an error dealing with `String`s, not that the error type is just a string. So, remove that noise.

There is known issue where PowerShell is unreasonably slow downloading files due to an issue with rendering the progress bar, see: PowerShell/PowerShell#2138 That issue is fixed in PowerShell Core (available in Azure Pipelines as pwsh.exe) but it can also be worked around by setting: $ProgressPreference = 'SilentlyContinue'

…ance to tag all allocations

Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>

error: remove StringError from Debug output Seeing `StringError("something something")` in debug output can cause someone to think there was an error dealing with `String`s, not that the error type is just a string. So, remove that noise. For example: ``` io error: Custom { kind: InvalidData, error: StringError("corrupt data") } ``` With this change: ``` io error: Custom { kind: InvalidData, error: "corrupt data" } ```

@oli-obk

…i-obk Miri: give machine the chance to tag all allocations r? @oli-obk The Miri side of this is at rust-lang#61278.

Speed up Azure CI installing Windows dependencies There is known issue where PowerShell is unreasonably slow downloading files due to an issue with rendering the progress bar, see this [issue](PowerShell/PowerShell#2138) That issue is fixed in PowerShell Core (available in Azure Pipelines as pwsh.exe) but it can also be worked around by setting: $ProgressPreference = 'SilentlyContinue' I measured downloading LLVM and it took about 220s before, 5s after, so the improvement is significant.

@Centril

…e_patterns, r=Centril Set ellipsis_inclusive_range_patterns lint to warn Continuing rust-lang#54910, the `ellipsis_inclusive_range_patterns` lint is set to warn. r? @Centril

…Centril Add regression test for const generics ICE Closes rust-lang#60879.

@Manishearth

… r=Manishearth Fix links in Deref documentation Fixes rust-lang#61358. In commonmark, the "link alias" has to be right after the link. Screenshot: <img width="970" alt="Screenshot 2019-05-30 at 19 01 58" src="https://user-images.githubusercontent.com/3050060/58650155-3b594e00-830e-11e9-956c-4dadefa40ff0.png"> r? @Manishearth

@Centril

…entril Stabilize iter_nth_back feature FCP done in rust-lang#56995 (comment) Closes rust-lang#56995 r? @Centril

Fixed lifetime misspelling

…omez Migrate some books to mdbook version 0.2 There are 3 books still using old version but they need more effort so I hope to do them in subsequent PR if I find the time.

@estebank

Explicitly suggest 'type_ascription' feature Closes: rust-lang#61325 r? @estebank

Centril · 2019-05-30T22:25:16Z

@bors r+ p=10 rollup=never

bors · 2019-05-30T22:25:17Z

📌 Commit 4254c25 has been approved by Centril

bors · 2019-05-31T00:50:21Z

⌛ Testing commit 4254c25 with merge f2b88a8362eee796ca03f296fc76f65f1695ae19...

bors · 2019-05-31T02:42:09Z

💔 Test failed - checks-travis

rust-highfive · 2019-05-31T02:42:11Z

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/__init__.py:83: RequestsDependencyWarning: Old version of cryptography ([1, 2, 3]) may cause slowdown.
  warnings.warn(warning, RequestsDependencyWarning)
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.
Collecting awscli
  Downloading https://files.pythonhosted.org/packages/ae/df/edd5e30bd7b7e6ffc541f44b922424d947be06b56fceb0d414b4164268ab/awscli-1.16.169-py2.py3-none-any.whl (1.6MB)
  Downloading https://files.pythonhosted.org/packages/d7/de/5737f602e22073ecbded7a0c590707085e154e32b68d86545dcc31004c02/s3transfer-0.2.0-py2.py3-none-any.whl (69kB)
Collecting docutils>=0.10 (from awscli)
  Downloading https://files.pythonhosted.org/packages/50/09/c53398e0005b11f7ffb27b7aa720c617aba53be4fb4f4f3f06b9b5c60f28/docutils-0.14-py2-none-any.whl (543kB)
Requirement already satisfied: PyYAML<=3.13,>=3.10 in /usr/lib/python2.7/dist-packages (from awscli) (3.11)
---
[01:48:09] test string::test_str_truncate ... ok
[01:48:09] test string::test_str_clear ... ok
[01:48:09] test string::test_str_truncate_invalid_len ... ok
[01:48:09] test string::test_str_truncate_split_codepoint ... ok
[01:48:09] died due to signal 11
[01:48:09] error: test failed, to rerun pass '-p alloc --test collectionstests'
[01:48:09] 
[01:48:09] 
[01:48:09] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--"
[01:48:09] 
[01:48:09] 
[01:48:09] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target arm-linux-androideabi
[01:48:09] Build completed unsuccessfully in 1:37:43
---
travis_time:end:026b7b8e:start=1559270432805800556,finish=1559270432822423938,duration=16623382
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:049e05c0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:36f20944
travis_time:start:36f20944
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:13906728
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2019-05-31T02:43:35Z

@bors retry

bors · 2019-05-31T02:44:04Z

⌛ Testing commit 4254c25 with merge b3475de...

@ghost

Rollup of 10 pull requests Successful merges: - #60897 (error: remove StringError from Debug output) - #61278 (Miri: give machine the chance to tag all allocations) - #61304 (Speed up Azure CI installing Windows dependencies) - #61342 (Set ellipsis_inclusive_range_patterns lint to warn) - #61344 (Add regression test for const generics ICE) - #61359 (Fix links in Deref documentation) - #61363 (Stabilize iter_nth_back feature) - #61369 (Fixed lifetime misspelling) - #61372 (Migrate some books to mdbook version 0.2) - #61374 (Explicitly suggest 'type_ascription' feature) Failed merges: r? @ghost

bors · 2019-05-31T06:44:04Z

💥 Test timed out

seanmonstar and others added 30 commits May 16, 2019 17:37

error: remove StringError from Debug output

d2d89b1

Seeing `StringError("something something")` in debug output can cause someone to think there was an error dealing with `String`s, not that the error type is just a string. So, remove that noise.

cache tag for vtable; fn_alloc's don't have a stack nor tag

07864a6

no longer assume that there is a default tag: give the machine the ch…

a218be9

…ance to tag all allocations

fix comments

19c4cfd

fix rebase fallout

c604350

turn comments into doc-comments

66cc1b7

fix indentation

b073599

FIXME

1a7ce02

update comments

5a8f6db

Set ellipsis_inclusive_range_patterns lint to warn

bf0da6c

Update ui and run-pass for ellipsis_inclusive_range_patterns lint

e18885e

Migrate unstable-book to MdBook2

3ffab36

Migrate rustdoc book to MdBook2

5f929be

Migrate nomicon book to MdBook2

dacf19c

Fix links in Deref documentation

436c9be

Stabilize iter_nth_back feature

0c35c69

Merge branch 'master' into iwr_progress

6c534c3

Add regression test for const generics ICE

0fdd419

Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>

Fixed lifetime misspelling

66aa18b

Explicitly suggest 'type_ascription' feature

4c5eb8e

Rollup merge of rust-lang#61278 - RalfJung:miri-tag-allocations, r=ol…

8996ebb

…i-obk Miri: give machine the chance to tag all allocations r? @oli-obk The Miri side of this is at rust-lang#61278.

Rollup merge of rust-lang#61342 - memoryruins:ellipsis_inclusive_rang…

30b3139

…e_patterns, r=Centril Set ellipsis_inclusive_range_patterns lint to warn Continuing rust-lang#54910, the `ellipsis_inclusive_range_patterns` lint is set to warn. r? @Centril

Rollup merge of rust-lang#61344 - varkor:const-failed-to-life-ice, r=…

4643a45

…Centril Add regression test for const generics ICE Closes rust-lang#60879.

Rollup merge of rust-lang#61363 - lzutao:stabilize-iter_nth_back, r=C…

27cb16a

…entril Stabilize iter_nth_back feature FCP done in rust-lang#56995 (comment) Closes rust-lang#56995 r? @Centril

Rollup merge of rust-lang#61369 - Vallentin:patch-1, r=varkor

79b6cff

Fixed lifetime misspelling

Rollup merge of rust-lang#61372 - mati865:books, r=Centril,GuillaumeG…

e35305c

…omez Migrate some books to mdbook version 0.2 There are 3 books still using old version but they need more effort so I hope to do them in subsequent PR if I find the time.

Rollup merge of rust-lang#61374 - VirrageS:master, r=Centril

4254c25

Explicitly suggest 'type_ascription' feature Closes: rust-lang#61325 r? @estebank

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 30, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 31, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 31, 2019

pietroalbini closed this May 31, 2019

Centril deleted the rollup-hx912ts branch May 31, 2019 12:02

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 10 pull requests #61379

Rollup of 10 pull requests #61379

Centril commented May 30, 2019

Centril commented May 30, 2019

bors commented May 30, 2019

bors commented May 31, 2019

bors commented May 31, 2019

rust-highfive commented May 31, 2019

Centril commented May 31, 2019

bors commented May 31, 2019

bors commented May 31, 2019

Rollup of 10 pull requests #61379

Rollup of 10 pull requests #61379

Conversation

Centril commented May 30, 2019

Centril commented May 30, 2019

bors commented May 30, 2019

bors commented May 31, 2019

bors commented May 31, 2019

rust-highfive commented May 31, 2019

Centril commented May 31, 2019

bors commented May 31, 2019

bors commented May 31, 2019